Add ping/pong heartbeating to WSClient, and fix concurrent map on config #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #420 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 277 277
Lines 14858 14939 +81
=========================================
+ Hits 14858 14939 +81
Continue to review full report at Codecov.
|
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
|
E2e failed due to #423 |
awrichar
reviewed
Jan 20, 2022
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
|
I added a fix to #298 into this PR, as I saw it pop on an e2e test. I introduced a separate |
awrichar
reviewed
Jan 21, 2022
| defer w.heartbeatMux.Unlock() | ||
|
|
||
| if isPong && w.activePingSent != nil { | ||
| log.L(w.ctx).Debugf("WS %s heartbeat completed (pong) after %.2fms", w.url, float64(time.Since(*w.activePingSent))/float64(time.Millisecond)) |
There was a problem hiding this comment.
Seems like this will get very chatty... But I guess it's at debug level.
awrichar
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary fix in this PR, is to add a heartbeat to the
WSClientconnections, to allow quicker detection of a case where the websocket between FireFly Core and a connector (EthConnect, FabConnect, DX) fails silently.The default is 30 seconds between sending
pingpackets, with a 30 second timeout.The feature can be disabled by setting the
heartbeatIntervalto zero on a given websocket client configuration.Example log output showing operation of the heartbeating:
Also added a fix for this intermittent UT failure, which could hit real environments - by changing the locking in
configto cover all cases of get/set concurrency: