DeployContract implementation for Tezos connector #1481

alex-semenyuk · 2024-03-20T08:17:15Z

Related PRs to firefly-tezosconnect and firefly-cli

Request example

{
   "key":"tz1V3spuktTP2wuEZP7D2hJruLZ5uJTuJk31",
   "contract":{
      "code":[
         {
            "args":[
               {
                  "prim":"string"
               }
            ],
            "prim":"parameter"
         },
         {
            "args":[
               {
                  "prim":"string"
               }
            ],
            "prim":"storage"
         },
         {
            "args":[
               [
                  {
                     "prim":"CAR"
                  },
                  {
                     "args":[
                        {
                           "prim":"operation"
                        }
                     ],
                     "prim":"NIL"
                  },
                  {
                     "prim":"PAIR"
                  }
               ]
            ],
            "prim":"code"
         }
      ],
      "storage":{
         "string":"hello world"
      }
   }
}

Response

{
  "id": "3caf86b2-be4d-40c2-9450-bd4af5340e4a",
  "namespace": "default",
  "tx": "b492cd22-2eff-4b78-a9f2-95da5db58e9b",
  "type": "blockchain_deploy",
  "status": "Pending",
  "plugin": "tezos",
  "input": {
    "contract": {
      "code": [
        {
          "args": [
            {
              "prim": "string"
            }
          ],
          "prim": "parameter"
        },
        {
          "args": [
            {
              "prim": "string"
            }
          ],
          "prim": "storage"
        },
        {
          "args": [
            [
              {
                "prim": "CAR"
              },
              {
                "args": [
                  {
                    "prim": "operation"
                  }
                ],
                "prim": "NIL"
              },
              {
                "prim": "PAIR"
              }
            ]
          ],
          "prim": "code"
        }
      ],
      "storage": {
        "string": "hello world!!!!"
      }
    },
    "definition": null,
    "input": null,
    "key": "tz1V3spuktTP2wuEZP7D2hJruLZ5uJTuJk31",
    "options": null
  },
  "created": "2024-03-19T21:06:22.871702Z",
  "updated": "2024-03-19T21:06:22.871702Z"
}

Signed-off-by: Alexey Semenyuk <[email protected]>

codecov-commenter · 2024-03-20T08:20:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (577e8c4) to head (f4be7bf).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1481   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         322      322           
  Lines       23406    23424   +18     
=======================================
+ Hits        23404    23422   +18     
  Misses          1        1           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

denisandreenko · 2024-03-21T14:43:17Z

internal/blockchain/tezos/tezos.go

+		t.metrics.BlockchainContractDeployment()
+	}
+	headers := TezosconnectMessageHeaders{
+		Type: "DeployContract",


It's better to have as constant, as these types are used by several chains

Thanks, done

denisandreenko · 2024-03-21T14:49:59Z

internal/blockchain/tezos/tezos.go

+	}
+	body, err = t.applyOptions(ctx, body, options)
+	if err != nil {
+		return true, err


For clarification, let's use resErr.SubmissionRejected instead as we did it below

resErr.SubmissionRejected is a bool value, applyOptions returns error

I mean, instead of 'true' value

Signed-off-by: Alexey Semenyuk <[email protected]>

alex-semenyuk · 2024-03-21T16:49:44Z

internal/blockchain/ethereum/ethereum.go

@@ -745,9 +745,7 @@ func (e *Ethereum) DeployContract(ctx context.Context, nsOpID, signingKey string
 		"definition": definition,
 		"contract":   contract,
 	}
-	if signingKey != "" {


This check doesn't make sense since at line 743 we already set "from" to signingKey

denisandreenko · 2024-03-22T09:12:00Z

internal/blockchain/tezos/tezos.go

+	}
+	body, err = t.applyOptions(ctx, body, options)
+	if err != nil {
+		return true, err


I mean, instead of 'true' value

alex-semenyuk added 2 commits March 19, 2024 00:31

Add support deploy contract for Tezos Connector

f9f77b6

Signed-off-by: Alexey Semenyuk <[email protected]>

Tests

5ada2cf

Signed-off-by: Alexey Semenyuk <[email protected]>

alex-semenyuk requested a review from a team as a code owner March 20, 2024 08:17

This was referenced Mar 20, 2024

DeployContract implementation for Tezos connector hyperledger/firefly-tezosconnect#36

Merged

Enable an instance of tezossigner to deploy a contract using FF core API hyperledger/firefly-cli#298

Merged

denisandreenko reviewed Mar 21, 2024

View reviewed changes

Make DeployContract as const

f4be7bf

Signed-off-by: Alexey Semenyuk <[email protected]>

alex-semenyuk force-pushed the tezos_deploy_contract branch from 2d58ba6 to f4be7bf Compare March 21, 2024 16:46

alex-semenyuk commented Mar 21, 2024

View reviewed changes

denisandreenko approved these changes Mar 22, 2024

View reviewed changes

nguyer approved these changes Apr 8, 2024

View reviewed changes

nguyer merged commit d460998 into hyperledger:main Apr 8, 2024
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DeployContract implementation for Tezos connector #1481

DeployContract implementation for Tezos connector #1481

alex-semenyuk commented Mar 20, 2024 •

edited

Loading

codecov-commenter commented Mar 20, 2024 •

edited

Loading

denisandreenko Mar 21, 2024

alex-semenyuk Mar 21, 2024

denisandreenko Mar 21, 2024

alex-semenyuk Mar 21, 2024

denisandreenko Mar 22, 2024

alex-semenyuk Mar 21, 2024

denisandreenko Mar 22, 2024

DeployContract implementation for Tezos connector #1481

DeployContract implementation for Tezos connector #1481

Conversation

alex-semenyuk commented Mar 20, 2024 • edited Loading

codecov-commenter commented Mar 20, 2024 • edited Loading

Codecov Report

denisandreenko Mar 21, 2024

Choose a reason for hiding this comment

alex-semenyuk Mar 21, 2024

Choose a reason for hiding this comment

denisandreenko Mar 21, 2024

Choose a reason for hiding this comment

alex-semenyuk Mar 21, 2024

Choose a reason for hiding this comment

denisandreenko Mar 22, 2024

Choose a reason for hiding this comment

alex-semenyuk Mar 21, 2024

Choose a reason for hiding this comment

denisandreenko Mar 22, 2024

Choose a reason for hiding this comment

alex-semenyuk commented Mar 20, 2024 •

edited

Loading

codecov-commenter commented Mar 20, 2024 •

edited

Loading