Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger on pull_request_target #20

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

alex-semenyuk
Copy link
Member

@alex-semenyuk alex-semenyuk commented Oct 30, 2023

In this PR#18 codecov wasn't triggered in comparison with this PR#17

This issue were described here

Solution is pull_request_target

In order to solve this, we’ve added a new pull_request_target event, which behaves in an almost identical way to the pull_request event with the same set of filters and payload. However, instead of running against the workflow and code from the merge commit, the event runs against the workflow and code from the base of the pull request. This means the workflow is running from a trusted source and is given access to a read/write token as well as secrets enabling the maintainer to safely comment on or label a pull request. This event can be used in combination with the private repository settings as well.

Important note it seems it works only for PR from main to main as mentioned here

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #20 (69da0ea) into main (c8b86f6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   39.97%   39.97%           
=======================================
  Files          22       22           
  Lines         848      848           
=======================================
  Hits          339      339           
  Misses        503      503           
  Partials        6        6           

@denisandreenko denisandreenko self-requested a review November 7, 2023 06:51
@denisandreenko denisandreenko merged commit 0421d0b into hyperledger:main Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants