Multiple Workers per Test Case #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hfuss <[email protected]>
onelapahead
requested review from
shorsher,
nguyer,
awrichar and
peterbroadhurst
as code owners
Signed-off-by: hfuss <[email protected]>
|
Do we intentionally check in the tarball at |
peterbroadhurst
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
looks great @hfuss - one comment to consider before merging.
Signed-off-by: hfuss <[email protected]>
|
@peterbroadhurst good call, on internal projects we like to vendor the chart deps but for these charts committing just the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prep.shto work with the new test configuration format that allows defining multiple instances and multiple test cases per instance with a varying number of workers per test casemonitoring/k8s.jsonsince its going to be tracked via Helm Chart for Grafana Dashboard(s) firefly-helm-charts#43 going forward