Optimize inquire.IsSubset #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change set makes IsSubset not use reflection for faster processing. FAB-17519 raised a concern that the peer's CPU spikes during evaluation of lots of combinations, and the captured CPU profile trace showed that reflection eats a lot of CPU cycles. Change-Id: I5859d585ae76f1cab204daac7ea461a60fe8f33d Signed-off-by: yacovm <[email protected]>
C0rWin
approved these changes
Feb 22, 2020
C0rWin
pushed a commit
to C0rWin/fabric
that referenced
this pull request
Sep 15, 2020
This change set makes IsSubset not use reflection for faster processing. FAB-17519 raised a concern that the peer's CPU spikes during evaluation of lots of combinations, and the captured CPU profile trace showed that reflection eats a lot of CPU cycles. Change-Id: I5859d585ae76f1cab204daac7ea461a60fe8f33d Signed-off-by: yacovm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set makes IsSubset not use reflection
for faster processing.
FAB-17519 raised a concern that the peer's CPU spikes
during evaluation of lots of combinations, and the captured
CPU profile trace showed that reflection eats a lot of CPU cycles.
Change-Id: I5859d585ae76f1cab204daac7ea461a60fe8f33d
Signed-off-by: yacovm [email protected]