Implement chaincode event replay for Fabric Gateway #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestbeforetoday
force-pushed
the
issue2792-2
branch
2 times, most recently
from
d1507f6 to
fbfec62
Compare
bestbeforetoday
changed the title
Signed-off-by: Mark S. Lewis <[email protected]>
bestbeforetoday
force-pushed
the
issue2792-2
branch
from
fbfec62 to
7747938
Compare
bestbeforetoday
changed the title
andrew-coleman
requested changes
Sep 7, 2021
internal/pkg/gateway/api.go
Outdated
| if err != nil { | ||
| return status.Error(codes.Unavailable, err.Error()) | ||
| var startBlock uint64 | ||
| switch seek := request.StartPosition.Type.(type) { |
There was a problem hiding this comment.
If StartPosition hasn't been specified in the request proto, then this will barf. Should we default to NextCommit in this case?
There was a problem hiding this comment.
Like you've done in the unit test :)
There was a problem hiding this comment.
I think I tried this and the protobuf unmarshalling failed because a oneof field wasn't defined in the message
There was a problem hiding this comment.
Having said that... the Golang protobuf docs have an example of switching on a oneof with nil as a possible value, so let me try that again
https://developers.google.com/protocol-buffers/docs/reference/go-generated#oneof
bestbeforetoday
force-pushed
the
issue2792-2
branch
2 times, most recently
from
cdfe7bd to
72a39b4
Compare
Signed-off-by: Mark S. Lewis <[email protected]>
bestbeforetoday
force-pushed
the
issue2792-2
branch
from
72a39b4 to
a6d586a
Compare
andrew-coleman
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2792