Exercise a full end-to-end flow with PKCS11 #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execute the basic query-invoke-query pattern against a solo network with BCCSP configured to use PKCS11. Signed-off-by: Matthew Sykes <[email protected]>
caod123
approved these changes
Aug 12, 2020
ale-linux
reviewed
Aug 12, 2020
| @@ -33,89 +33,106 @@ import ( | |||
| "github.com/tedsuo/ifrit" | |||
| ) | |||
|
|
|||
| var _ = Describe("Configures PKCS#11 for peer and orderer", func() { | |||
| var _ = Describe("PKCS11 enabled network", func() { | |||
There was a problem hiding this comment.
Very minor but the real name of the standard is PKCS #11 (see here https://en.wikipedia.org/wiki/PKCS_11). So while the previous string was incorrect due to the missing space, your's isn't correct either. If you are okay with changing I'd change it here and everywhere else.
| orgAdminMSPPath := network.PeerUserMSPDir(peer, "Admin") | ||
| updateMSPFolder(orgAdminMSPPath, fmt.Sprintf("Admin@%s-cert.pem", domain), newAdminPemCert) | ||
|
|
||
| By("Updating the peer user1 signcerts") |
There was a problem hiding this comment.
Let me see if I understand why you added this step: by updating the user cert (that is, the one the CLI will use to sign proposal and transaction), are you ensuring that PKCS #11 is also used by the CLI? Assuming I got this right, would you agree that this would never happen in production since proposal/tx signing will be performed by the SDK which we don't exercise here?
wlahti
pushed a commit
to wlahti/fabric
that referenced
this pull request
Oct 2, 2020
Execute the basic query-invoke-query pattern against a solo network with BCCSP configured to use PKCS11. Signed-off-by: Matthew Sykes <[email protected]>
ale-linux
pushed a commit
that referenced
this pull request
Oct 5, 2020
Execute the basic query-invoke-query pattern against a solo network with BCCSP configured to use PKCS11. Signed-off-by: Matthew Sykes <[email protected]>
wlahti
pushed a commit
to wlahti/fabric
that referenced
this pull request
Oct 13, 2020
Execute the basic query-invoke-query pattern against a solo network with BCCSP configured to use PKCS11. Signed-off-by: Matthew Sykes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute the basic query-invoke-query pattern against a solo network with BCCSP configured to use PKCS11.