Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger comparison utility - Private data comparison #2818

Closed
jcastrence opened this issue Aug 9, 2021 · 1 comment · Fixed by #2861
Closed

Ledger comparison utility - Private data comparison #2818

jcastrence opened this issue Aug 9, 2021 · 1 comment · Fixed by #2861

Comments

@jcastrence
Copy link
Contributor

jcastrence commented Aug 9, 2021 •
edited
Loading

Generate a list of differences between the private data in a separate json output file when running the compare command.
@denyeart denyeart changed the title Private Data Compare Flag Ledger comparison utility - Private data compare flag Aug 10, 2021
@denyeart
Copy link
Contributor

@jcastrence I was thinking we should always compare both public and private data, rather than having a flag option.
What do you think @manish-sethi ?

@jcastrence jcastrence changed the title Ledger comparison utility - Private data compare flag Ledger comparison utility - Private data compare Aug 10, 2021
@jcastrence jcastrence changed the title Ledger comparison utility - Private data compare Ledger comparison utility - Private data comparison Aug 10, 2021
@jcastrence jcastrence mentioned this issue Aug 27, 2021
Merged
jcastrence pushed a commit to jcastrence/fabric that referenced this issue Sep 2, 2021
@jrc-ibm
Private Data Comparison
bd3971b 
Resolves hyperledger#2818

Signed-off-by: Julian Castrence <[email protected]>
denyeart pushed a commit that referenced this issue Sep 3, 2021
@jrc-ibm @denyeart
Private Data Comparison
b1d7538 
Resolves #2818

Signed-off-by: Julian Castrence <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Private Data Comparison jcastrence/fabric
2 participants
@denyeart @jcastrence