[FAB-3645] adding cc bytes instead of its hash

Bug in computing the hash caused ChaincodeDeploymentSpec.CodePackage to be set instead of its hash causing payload bloat. Change-Id: I83dbea5667b1709e9e22951b19585302b3168033 Signed-off-by: Srinivasan Muralidharan <[email protected]>
hyperledger · May 5, 2017 · 3d169cc · 3d169cc
1 parent 1d31ce3
commit 3d169cc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/core/common/ccprovider/cdspackage.go b/core/common/ccprovider/cdspackage.go
@@ -146,7 +146,8 @@ func (ccpack *CDSPackage) getCDSData(cds *pb.ChaincodeDeploymentSpec) ([]byte, [
 	cdsdata := &CDSData{}
 
 	//code hash
-	cdsdata.CodeHash = hash.Sum(cds.CodePackage)
+	hash.Write(cds.CodePackage)
+	cdsdata.CodeHash = hash.Sum(nil)
 
 	hash.Reset()
 

diff --git a/core/common/ccprovider/sigcdspackage.go b/core/common/ccprovider/sigcdspackage.go
@@ -160,7 +160,8 @@ func (ccpack *SignedCDSPackage) getCDSData(scds *pb.SignedChaincodeDeploymentSpe
 	scdsdata := &SignedCDSData{}
 
 	//get the code hash
-	scdsdata.CodeHash = hash.Sum(cds.CodePackage)
+	hash.Write(cds.CodePackage)
+	scdsdata.CodeHash = hash.Sum(nil)
 
 	hash.Reset()