Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FABN-1524: Default file checkpointer implementation #201

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

bestbeforetoday
Copy link
Member

No description provided.

@bestbeforetoday bestbeforetoday requested a review from a team as a code owner March 27, 2020 17:45
@bestbeforetoday bestbeforetoday force-pushed the FABN-1524 branch 2 times, most recently from 441728c to 83e6202 Compare March 28, 2020 09:21
Copy link
Contributor

@heatherlp heatherlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heatherlp heatherlp merged commit 0e8dfa8 into hyperledger:master Mar 30, 2020
@heatherlp
Copy link
Contributor

So the merge build failed on the commit, but only on node 12. I tried to recreate it by rebasing and pushing my fork twice and I couldn't. So it might have been a one time thing, or perhaps it's a merge only thing - it's worth keeping an eye on

@ryjones
Copy link
Contributor

ryjones commented Mar 30, 2020

there are capacity issues a Azure; perhaps that caused a flake?

@bestbeforetoday bestbeforetoday deleted the FABN-1524 branch April 23, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants