Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FABN-1519: More robust private data scenario test #193

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

bestbeforetoday
Copy link
Member

The ordering of the Then assertions required waits to be introduced
to minimise timing issues causing spurious failures. Re-ordered to
ensure tests happen only when there is data available to test.

@bestbeforetoday bestbeforetoday force-pushed the FABN-1519 branch 5 times, most recently from 6173f95 to 19c2516 Compare March 20, 2020 12:40
The ordering of the Then assertions required waits to be introduced
to minimise timing issues causing spurious failures. Re-ordered to
ensure tests happen only when there is data available to test.

Signed-off-by: Mark S. Lewis <[email protected]>
@bestbeforetoday bestbeforetoday marked this pull request as ready for review March 20, 2020 13:27
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner March 20, 2020 13:27
@harrisob harrisob merged commit abe6e78 into hyperledger:master Mar 20, 2020
@bestbeforetoday bestbeforetoday deleted the FABN-1519 branch April 23, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants