FABN-1491: Updated realtime block event listening #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestbeforetoday
force-pushed
the
FABN-1491
branch
3 times, most recently
from
f879515 to
29a1287
Compare
Signed-off-by: Mark S. Lewis <[email protected]>
bestbeforetoday
force-pushed
the
FABN-1491
branch
from
29a1287 to
5e93c12
Compare
harrisob
reviewed
Feb 26, 2020
| * events from all peers in the client identity's organization. | ||
| * The [submitTransaction]{@link module:fabric-network.Contract#submitTransaction} function will wait until successful | ||
| * events are received from <em>all</em> currently connected peers (minimum 1). | ||
| * @property {module:fabric-network.TxEventHandlerFactory} MSPID_SCOPE_ALLFORTX Listen for transaction commit |
There was a problem hiding this comment.
I moved the scope of TxEventHandlerFactory to the top level instead of nested within Gateway (or wherever it was nested before). This makes the JSDoc match the existing TypeScript definitions.
|
|
||
| await network.addBlockListener(listener); | ||
| eventService.sendEvent(event2); | ||
| eventService.sendEvent(event1); // Ignored as older than first block received |
There was a problem hiding this comment.
We will have to warn the user that if the first block is received out of order they will miss blocks
There was a problem hiding this comment.
This is only for realtime listening. In that case you get all blocks (in order) with a larger block number than the first one the client sees. For replay you get from exactly the block you specified. Nothing gets missed.
andrew-coleman
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.