Use elliptic instead of @noble/curves for Node crypto #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@noble/curves` has a dependency on `@noble/hashes`, and this throws an error on module load if it detects a big-endian platform since it does not function correctly on big-endian systems. This change uses dynamic module loading to avoid loading `@noble/curves` unless one of the default ECDSA signer implementations is created. Users of big-endian systems can create their own signer implementation, perhaps based on Node's crypto implementation instead. Signed-off-by: Mark S. Lewis <[email protected]>
bestbeforetoday
force-pushed
the
s390x
branch
2 times, most recently
from
52a230f to
b8de7aa
Compare
@noble/curves makes use of @noble/hashes, which does not function correctly on big-endian systems, and also throws an error on module load if a big-endian system is detected. Revert to using elliptic as the ECDSA signing implementation. Signed-off-by: Mark S. Lewis <[email protected]>
bestbeforetoday
force-pushed
the
s390x
branch
from
b8de7aa to
dbd3c31
Compare
bestbeforetoday
changed the title
andrew-coleman
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@noble/curvesmakes use of@noble/hashes, which does not function correctly on big-endian systems, and also throws an error on module load if a big-endian system is detected. Revert to usingellipticas the ECDSA signing implementation.Closes #628