Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.2 release candidate: web3 version change, mqtt fixes, fabric gateway fixes #863

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

nklincoln
Copy link
Contributor

@nklincoln nklincoln commented Jun 9, 2020

Signed-off-by: [email protected] [email protected]

closes #860
closes #848
closes #847
closes #838

Changes to Travis

  • bump travis nodeJS level to 10

Changes to bindings

  • Bump ethereum web3 level to 1.2.2
  • Align fabric SDK bindings to the version of SDK (fabric-network removed from early bindings)

Changes to integration test:

  • Add additional phase for binding to Fabric v2.1.0 SDK
  • Add target peer specification to query benchmark
  • Add explicit phase resources for gateway based tests
  • Modified Besu docker compose file

Changes to messenger:

  • There was an MQTT error on disconnect resulting in a hanging process, which was undetected previously due to only having a single test run. Not forcing the close and passing an empty Options object instead of undefined solved this and allows the benchmark to complete correctly

Logging:

  • In hunting for the above error, I added some more logging on key phases. Makes sense to leave these in

Buffer:

  • Instances of new Buffer replaced with Buffer.from() to get rid of the security warnings

worker-orchestrator:

  • removed the redundant killing of processes in the this.workerObjects array, since we now clean up workers within the messenger with a process.exit(0) in the message handler

Fabric.js

  • Switch on the version to use is now performed on the installed version of the fabric-network package, and not the fabric-client. This proved more stable within the integration tests
  • Ensure gateway use of V1 can only occur on versions where the required default strategies exists (1.4.2 and above)

Fabric-Gateway-v1:

  • Actually set a peer cache so that target peers may be used, but warn and skip this on versions that cannot set target peers on transactions (must be 1.4.5 and greater)
  • Rename passed arg transientData to transientMap to match docs
  • Override the query timeout on the gateway

Fabric-Gateway-v2:

  • Logging mod provided for view purposes (happy to revert)
  • Performs validation after variable setting for discovery option
  • Rename passed arg transientData to transientMap to match docs

@nklincoln nklincoln requested a review from aklenik June 9, 2020 21:27
@nklincoln nklincoln force-pushed the v032-bugfix-release branch 2 times, most recently from 2dff9d6 to f7d3f50 Compare June 10, 2020 08:35
@nklincoln nklincoln force-pushed the v032-bugfix-release branch 3 times, most recently from 080ea53 to 8237e49 Compare June 10, 2020 09:53
@aklenik aklenik self-assigned this Jun 10, 2020
@nklincoln nklincoln force-pushed the v032-bugfix-release branch 4 times, most recently from 68f76d9 to 7e3b1a4 Compare June 10, 2020 14:00
@nklincoln nklincoln changed the title Fix fabric v2 validation and ethereum web3 level 0.3.2 release: web3 version change, mqtt fixes, fabric gateway fixes Jun 10, 2020
@nklincoln nklincoln force-pushed the v032-bugfix-release branch from 7e3b1a4 to c043b52 Compare June 10, 2020 14:21
@nklincoln nklincoln changed the title 0.3.2 release: web3 version change, mqtt fixes, fabric gateway fixes 0.3.2 release candidate: web3 version change, mqtt fixes, fabric gateway fixes Jun 10, 2020
Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aklenik aklenik merged commit c9de977 into hyperledger-caliper:master Jun 11, 2020
@nklincoln nklincoln deleted the v032-bugfix-release branch June 25, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment