Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fabric v2 adaptor doesn't work with discovery #860

Closed
nklincoln opened this issue Jun 8, 2020 · 0 comments · Fixed by #863
Closed

fabric v2 adaptor doesn't work with discovery #860

nklincoln opened this issue Jun 8, 2020 · 0 comments · Fixed by #863
Assignees
@nklincoln
Labels
bug Something isn't working

Comments

@nklincoln
Copy link
Contributor

Current implementation runs the network validation before the 'discovery' parameter is evaluated. Which is unfortunate, because it then fails all validation instances where having 'discovery: true` would have let it pass.

Looks like this would be fixed by #853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nklincoln nklincoln

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

0.3.2 release candidate: web3 version change, mqtt fixes, fabric gateway fixes nklincoln/caliper
1 participant
@nklincoln