Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging style flexibility #607

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

aklenik
Copy link
Contributor

@aklenik aklenik commented Oct 7, 2019

Signed-off-by: Attila Klenik [email protected]

The new logging formats introduced by #598 were not flexible enough to create consistent all-line coloring, for example (and also had issues with JSON formatting). This PR fixes that by using a more flexible color and attribute formatter, and a strictly ordered formatting pipeline.

@aklenik aklenik added this to the v0.2.0 milestone Oct 9, 2019
Copy link
Contributor

@nklincoln nklincoln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@aklenik aklenik merged commit 6f599cb into hyperledger-caliper:master Oct 16, 2019
@aklenik aklenik deleted the log-style branch October 17, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants