Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance logging subsystem with flexible customization #598

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Enhance logging subsystem with flexible customization #598

merged 1 commit into from
Oct 3, 2019

Conversation

aklenik
Copy link
Contributor

@aklenik aklenik commented Oct 2, 2019

Signed-off-by: Attila Klenik [email protected]

Resolves #581
The PR includes:

  1. Changing to winston 3.X, to utilize the new formats feature
  2. Restructure the logging section of the runtime settings
    1. Keep implementation-specific options separated for target transports
    2. Make targets easy to disable/enable
    3. Make logging style easily configurable
    4. Provide a message structure template
  3. Related docs in other PR

@aklenik aklenik mentioned this pull request Oct 2, 2019
Merged
@aklenik aklenik force-pushed the logging-enhancement branch from 4484aef to ac5f43e Compare October 2, 2019 14:29
nklincoln
nklincoln approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@nklincoln nklincoln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled code and ran locally 👍

@aklenik aklenik merged commit 0f4eb36 into hyperledger-caliper:master Oct 3, 2019
@aklenik aklenik deleted the logging-enhancement branch October 3, 2019 10:42
@aklenik aklenik mentioned this pull request Oct 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nklincoln nklincoln nklincoln approved these changes

@feihujiang feihujiang Awaiting requested review from feihujiang

@jiangyaoguo jiangyaoguo Awaiting requested review from jiangyaoguo

@liam-grace liam-grace Awaiting requested review from liam-grace

@panyu4 panyu4 Awaiting requested review from panyu4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delegate logging settings (and docs) entirely to winston
2 participants
@aklenik @nklincoln