increase mainnet & Sepolia gas limit to 36M #8249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from BesuControllerBuilder Signed-off-by: Daniel Lehrner <[email protected]>
|
The system call gas limit is 30M regardless of the block gas limit |
daniellehrner
changed the title
Signed-off-by: Daniel Lehrner <[email protected]>
daniellehrner
commented
Feb 6, 2025
| @@ -18,12 +18,12 @@ | |||
| "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", | |||
| "prevRandao": "0x0000000000000000000000000000000000000000000000000000000000000000", | |||
| "blockNumber": "0x1", | |||
| "gasLimit": "0x1c9c380", | |||
| "gasLimit": "0x1ca35ef", | |||
There was a problem hiding this comment.
the gasLimit has changed because the new limit is 36M: We start with a block of 30M and increase gas limit for the next block by 30M / 1024.
Signed-off-by: Daniel Lehrner <[email protected]>
garyschulte
approved these changes
Feb 6, 2025
| @@ -79,7 +79,7 @@ public class MergeCoordinator implements MergeMiningCoordinator, BadChainListene | |||
| */ | |||
| private static final double TRY_FILL_BLOCK = 1.0; | |||
|
|
|||
| private static final long DEFAULT_TARGET_GAS_LIMIT = 30000000L; | |||
| private static final long DEFAULT_TARGET_GAS_LIMIT = 36_000_000L; | |||
| * href="https://eips.ethereum.org/EIPS/eip-2935#block-processing">EIP-2935</a> This value is | ||
| * independent of the gas limit of the block | ||
| */ | ||
| private static final long SYSTEM_CALL_GAS_LIMIT = 30_000_000L; |
There was a problem hiding this comment.
if anything triggers an issue in pectra, I bet it would be some client using the block limit for system call gas limit
fab-10
approved these changes
Feb 11, 2025
|
Please add a CHANGELOG entry |
… the one for mainnet Signed-off-by: Daniel Lehrner <[email protected]>
|
@daniellehrner is this one ready to merge? |
Yes, I think it is. I am just need to get the CI to pass |
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Sets the mainnet gas limit to 36M. Sets the gas limit for Sepolia, Holesky and Ephemery to
DEFAULT_TARGET_GAS_LIMIT_TESTNET. The idea is to have a separate constant for tesnets in order to increase the gas limt there first before we do it on mainnet.This PR also removes
GasLimitCalculatorfromBesuControllerBuilder, becauseBesuControllerdoes not use it. It seems it was removed at some point, but was still present as dead code inBesuControllerBuilder.Fixed Issue(s)
fixes #8245
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests