Fix eth_feeHistory rewards when bounded by configuration #7750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
force-pushed
the
fix-eth_feeHistory-rewards
branch
from
b35d2f1 to
f09bc23
Compare
Filter94
reviewed
Oct 9, 2024
| List<Wei> rewards = ethFeeHistory.computeRewards(rewardPercentiles, block, Wei.of(8)); | ||
|
|
||
| // Define the expected bounded rewards for each percentile | ||
| List<Wei> expectedBoundedRewards = Stream.of(4, 4, 4, 4, 5, 6, 6, 6, 6).map(Wei::of).toList(); |
There was a problem hiding this comment.
I don't get this test. If lower bound is set to 10 Wei, why are we getting values lower than that?
There was a problem hiding this comment.
in this case minGasPrice is 10wei, and since baseFee is 8wei, the calculated min priority fee (necessary to get the tx minable) is 2wei that is greater than the configured minPriorityFeePerGas=0 so the former is used.
Then the rewards (effective priority fees) are bounded by 200 and 300 coefficients, so the rewards must be in the interval 4wei and 6wei
There was a problem hiding this comment.
Ok, I'm following it now, thanks!
macfarla
approved these changes
Oct 11, 2024
macfarla
reviewed
Oct 11, 2024
CHANGELOG.md
Outdated
| @@ -31,6 +31,7 @@ | |||
| - Fix an unhandled PeerTable exception [#7733](https://github.com/hyperledger/besu/issues/7733) | |||
| - Fix RocksDBException: Busy leading to MerkleTrieException: Unable to load trie node value [#7745](https://github.com/hyperledger/besu/pull/7745) | |||
| - If a BFT validator node is syncing, pause block production until sync has completed [#7657](https://github.com/hyperledger/besu/pull/7657) | |||
| - Fix eth_feeHistory rewards when bounded by configuration [#7750](https://github.com/hyperledger/besu/pull/7750) | |||
There was a problem hiding this comment.
prob needs moving to next release section
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
fix-eth_feeHistory-rewards
branch
from
f09bc23 to
1e7d6fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The issue is that, when bounding rewards returned by
eth_feeHistoryby configuration, theminPriorityFeePerGasruntime value is used, but it could not be great enough to return acceptable values in order to estimate whichpriorityFeePerGasto use in a tx to ensure it is paying enough to be mineable.To fix that a a mineable lower bound for the priority fee is calculated and used in place of
minPriorityFeePerGasconf value, when it is greater that the latter, so we are reasonably sure that we are returning value that can be used to estimate the priority fee when submitting new txs.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests