Fix unhandled exception

[pinges]

PR description

Fixes an unhandled exception:

{"@timestamp":"2024-10-08T01:07:36,808","level":"ERROR","thread":"vert.x-eventloop-thread-3","class":"ContextImpl","message":"Unhandled exception","throwable":" java.util.NoSuchElementException\n\tat 1.next(CircularFifoQueue.java:385)\n\tat java.base/java.util.AbstractCollection.contains(AbstractCollection.java:112)\n\tat org.hyperledger.besu.ethereum.p2p.discovery.internal.PeerTable.isIpAddressInvalid(PeerTable.java:217)\n\tat

Fixes #7733

[macfarla]

can you add a test to show the problem that is fixed

[pinges]

can you add a test to show the problem that is fixed

That is really hard, as the problem was a race condition.
In the code we were iterating over the collection, checking hasNext(), then getNext(). In the Implementation of getNext() in the collection the first thing that is done is checking hasNext(), which failed and threw the NoSuchElementException.

[pinges]

Suggested change

	- Fix an undhandled exception. [#7733](https://github.com/hyperledger/besu/issues/7733)
	- Fix an unhandled exception. [#7733](https://github.com/hyperledger/besu/issues/7733)

[siladu]

LGTM

[macfarla]

can you add a test to show the problem that is fixed

That is really hard, as the problem was a race condition. In the code we were iterating over the collection, checking hasNext(), then getNext(). In the Implementation of getNext() in the collection the first thing that is done is checking hasNext(), which failed and threw the NoSuchElementException.

ok fair enough