Keep track of blobs that are part of multiple transactions #7723
Conversation
| @@ -107,8 +108,8 @@ public class TransactionPool implements BlockAddedObserver { | |||
| private final SaveRestoreManager saveRestoreManager = new SaveRestoreManager(); | |||
| private final Set<Address> localSenders = ConcurrentHashMap.newKeySet(); | |||
| private final EthScheduler.OrderedProcessor<BlockAddedEvent> blockAddedEventOrderedProcessor; | |||
| private final Map<VersionedHash, BlobsWithCommitments.BlobQuad> mapOfBlobsInTransactionPool = | |||
| new HashMap<>(); | |||
| private final Map<VersionedHash, List<BlobsWithCommitments.BlobQuad>> | |||
There was a problem hiding this comment.
This need to support concurrency, since notifications are sent async by potentially multiple threads
There was a problem hiding this comment.
There was a problem hiding this comment.
The access to the map was synchronized, but using a map implementation that does the synchronization for me is probably a better idea!
My first idea was to have a reference count, but this has the drawback that you potentially keep an additional blob in memory, while the list has the drawback of using a little more storage and it is a little slower. |
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPool.java
Outdated
Show resolved
Hide resolved
…ransactions/TransactionPool.java initial size to 1 Signed-off-by: Stefan Pingel <[email protected]>
PR description
The same blob can be part of multiple transactions. This PR makes sure that these blobs can be returned by
eth_getBlobsV1even when only one transaction containing that blob is still in the transaction pool.