7536 use head for snap sync #7718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin King <[email protected]>
Signed-off-by: Kevin King <[email protected]>
kingnhcomcast
force-pushed
the
7536-UseHeadForSnapSync
branch
from
ca75702 to
5a43468
Compare
garyschulte
reviewed
Oct 2, 2024
...th/src/main/java/org/hyperledger/besu/ethereum/eth/sync/fastsync/PivotSelectorFromBlock.java
Outdated
Show resolved
Hide resolved
garyschulte
requested changes
Oct 2, 2024
| @Override | ||
| public Optional<FastSyncState> selectNewPivotBlock() { | ||
| final Optional<ForkchoiceEvent> maybeForkchoice = forkchoiceStateSupplier.get(); | ||
| if (maybeForkchoice.isPresent() && maybeForkchoice.get().hasValidSafeBlockHash()) { |
There was a problem hiding this comment.
hasValidSafeBlockHash() isn't necessary for the head block implementation. I would suggest making getPivotHash return Optional, and you can do the safe block check there and return Optional.empty() if it doesn't exist.
this is a very corner case, where we would be trying to sync a network very near genesis, before any block has been marked 'safe'. The prior implementation of safe-only would have the same issue. So this isn't a huge deal, but fixing it now might save a headache in the future for sync tests or something like that where we would be syncing a brand new chain.
There was a problem hiding this comment.
makes sense, applied changes
Signed-off-by: Kevin King <[email protected]>
Signed-off-by: kingnhcomcast <[email protected]>
Signed-off-by: Kevin King <[email protected]>
2 tasks
siladu
added a commit
to siladu/besu
that referenced
this pull request
Oct 14, 2024
This reverts commit a7e1f6a. Signed-off-by: Simon Dudley <[email protected]>
siladu
added a commit
that referenced
this pull request
Oct 15, 2024
This reverts commit a7e1f6a. Signed-off-by: Simon Dudley <[email protected]>
FlorianHuc
pushed a commit
to FlorianHuc/besu
that referenced
this pull request
Oct 15, 2024
…7767) This reverts commit a7e1f6a. Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: FlorianHuc <[email protected]>
FlorianHuc
pushed a commit
to FlorianHuc/besu
that referenced
this pull request
Oct 15, 2024
…7767) This reverts commit a7e1f6a. Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: FlorianHuc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
fixes #7536
Default is sync to head, added config option 'Xsnapsync-to-head-enabled' which can be set to false to revert to older sync to safe block.
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests