Disable body validation for POS networks during sync #7646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
…o sync_pos_body_validation
jframe
changed the title
pinges
reviewed
Sep 20, 2024
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/BlockValidator.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Jason Frame <[email protected]>
daniellehrner
pushed a commit
to daniellehrner/besu
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Jason Frame <[email protected]> Co-authored-by: Stefan Pingel <[email protected]>
Wolmin
pushed a commit
to lukso-network/network-besu
that referenced
this pull request
Sep 27, 2024
Signed-off-by: Jason Frame <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: Wolmin <[email protected]>
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
For POS networks this disables the body validation during sync import. This is unnecessary since we trust the chain since the CL has given us the tip of the chain to use. We still validate the transactions root, ommers root, receipts root, and withdrawals root during the download of the block bodies and transactions to verify we have the correct block bodies and receipts.
For non-POS networks body validation now skips validating transaction and receipts root during the sync as this is already done when downloading the block bodies and transaction receipts.
When body validation is used outside of syncing, the default original full validation mode is being used. This PR only affects the behaviour of the body validation during syncing.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests