Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock evmtool code-validate into runtime mode #7397

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Jul 29, 2024

PR description

To conform to fuzzing practices, code-validate expects all code to be
runtime code.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

To conform to fuzzing practices, `code-validate` expects all code to be
runtime code.

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
Copy link
Contributor Author

shemnon commented Jul 29, 2024

Addresses ipsilon/eof#146 (comment) for besu

@shemnon shemnon enabled auto-merge (squash) July 30, 2024 15:17
@shemnon shemnon merged commit 9592b64 into hyperledger:main Jul 30, 2024
40 checks passed
@shemnon shemnon deleted the eof/code-validate-runtime branch August 2, 2024 13:17
gconnect pushed a commit to gconnect/besu that referenced this pull request Aug 26, 2024
To conform to fuzzing practices, `code-validate` expects all code to be
runtime code.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: gconnect <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants