Fix name of parameter for WithdrawalRequest #7122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS: this needs to be backported to a pectra branch. |
Signed-off-by: Lucas Saldanha <[email protected]>
lucassaldanha
force-pushed
the
fix-withdrawal-request-param
branch
from
5be2f3a to
7e419ad
Compare
macfarla
approved these changes
May 19, 2024
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
May 28, 2024
Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Lucas Saldanha <[email protected]>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Lucas Saldanha <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The name of the parameter should be
validatorPublicKey. This change 7e78da6 tried to fix it but only made the change in the @JsonProperty in the constructor, that is used for deserialization.To fix this, we need to fix it on the getter method with the @JsonGetter annotation. This is what is used for serialization and infers the name of the field from the name of the getter method. So
getValidatorPublicKeybecomesvalidatorPublicKeywhen serializing to json.I have also removed the method
asJsonObjectbecause it is not being used.