-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Web3j dependencies #6811
Conversation
85c9ee2
to
8d8c6c6
Compare
@@ -17,6 +17,10 @@ | |||
pluginManagement { | |||
repositories { | |||
gradlePluginPortal() | |||
maven { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? There are no plugins from the tech.pegasys
namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is needed because new web3j plugin has tech.pegasys:jc-kzg-4844
as dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not good. Web3j cannot be loaded entirely from maven central? Consensys should invest time in getting these published to Maven Central.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know someone is already working on that, so this will not be required in a future version, in the meantime what you prefer, using version 4.10.0
of the plugin or temporarily keeping the extra repo here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have the repository in our general listings. I was hoping we could keep the plugins section minimal. So this is acceptable since a long term solution is progressing.
6310814
to
a370514
Compare
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
a370514
to
5c0f303
Compare
# Conflicts: # CHANGELOG.md
* Update Web3j dependencies Signed-off-by: Fabio Di Fabio <[email protected]> * Force old version of the solidity compiler to pass AT Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: amsmota <[email protected]>
* Update Web3j dependencies Signed-off-by: Fabio Di Fabio <[email protected]> * Force old version of the solidity compiler to pass AT Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: amsmota <[email protected]>
* Update Web3j dependencies Signed-off-by: Fabio Di Fabio <[email protected]> * Force old version of the solidity compiler to pass AT Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]>
* Update Web3j dependencies Signed-off-by: Fabio Di Fabio <[email protected]> * Force old version of the solidity compiler to pass AT Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]>
PR description
Compilation is failing due some web3j artifacts not available anymore, so just updating them to latest verison
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests