-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transaction call object to accept both input and data field if equal #6702
Transaction call object to accept both input and data field if equal #6702
Conversation
…being set if equal Signed-off-by: Friedemann Fürst <[email protected]>
Signed-off-by: Friedemann Fürst <[email protected]>
Signed-off-by: Friedemann Fürst <[email protected]>
We might want to adjust the documentation here to specify this behavior: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. test cases make it clear. Thanks for your contribution @friedemannf
Thanks for this - added |
…yperledger#6702) * relax JsonCallParameter constructor to allow for both input and data being set if equal Signed-off-by: Friedemann Fürst <[email protected]> * fix: format Signed-off-by: Friedemann Fürst <[email protected]> * add changelog entry Signed-off-by: Friedemann Fürst <[email protected]> --------- Signed-off-by: Friedemann Fürst <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: MASDXI <[email protected]>
…yperledger#6702) * relax JsonCallParameter constructor to allow for both input and data being set if equal Signed-off-by: Friedemann Fürst <[email protected]> * fix: format Signed-off-by: Friedemann Fürst <[email protected]> * add changelog entry Signed-off-by: Friedemann Fürst <[email protected]> --------- Signed-off-by: Friedemann Fürst <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: amsmota <[email protected]>
…yperledger#6702) * relax JsonCallParameter constructor to allow for both input and data being set if equal Signed-off-by: Friedemann Fürst <[email protected]> * fix: format Signed-off-by: Friedemann Fürst <[email protected]> * add changelog entry Signed-off-by: Friedemann Fürst <[email protected]> --------- Signed-off-by: Friedemann Fürst <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: amsmota <[email protected]>
…yperledger#6702) * relax JsonCallParameter constructor to allow for both input and data being set if equal Signed-off-by: Friedemann Fürst <[email protected]> * fix: format Signed-off-by: Friedemann Fürst <[email protected]> * add changelog entry Signed-off-by: Friedemann Fürst <[email protected]> --------- Signed-off-by: Friedemann Fürst <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Most advanced CI tests are deferred until PR approval, but you could:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests
PR description
#6094 introduced the option to provide the calldata via the input field instead of the deprecated data field. It also introduced a check that prevents both field from being set. This seems overly strict as it prevents clients from setting both fields to remain backward-compatible. This PR relaxes the check to only fail if both fields are set and they are not equal.
Fixed Issue(s)
fixes #6697