Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction simulation service #6686

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Mar 6, 2024

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • locally run all unit tests via: ./gradlew build
  • locally run all acceptance tests via: ./gradlew acceptanceTest
  • locally run all integration tests via: ./gradlew integrationTest
  • locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

PR description

Introduce TransactionSimulationService so plugins can simulate txs processing

Fixed Issue(s)

Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10 fab-10 force-pushed the transaction-simulation-service branch from 61b49ab to dbfa5bc Compare March 7, 2024 11:58
@fab-10 fab-10 marked this pull request as ready for review March 7, 2024 13:20
# Conflicts:
#	CHANGELOG.md
#	acceptance-tests/dsl/src/main/java/org/hyperledger/besu/tests/acceptance/dsl/node/ThreadBesuNodeRunner.java
+ ", payloadSize="
+ (payload != null ? payload.size() : "null")
+ ", accessListSize="
+ accessList.map(List::size)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this auto-generated? accessList.size() would achieve the same result?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no because accessList is Optional

Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment.

@fab-10 fab-10 enabled auto-merge (squash) March 13, 2024 15:27
@fab-10 fab-10 merged commit 4cc6b74 into hyperledger:main Mar 13, 2024
42 checks passed
@fab-10 fab-10 deleted the transaction-simulation-service branch March 13, 2024 15:58
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: amsmota <[email protected]>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: amsmota <[email protected]>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants