-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and extend PluginTransactionPoolValidatorService #6636
Merged
fab-10
merged 5 commits into
hyperledger:main
from
fab-10:txpool-validator-service-refactor-extend
Mar 5, 2024
Merged
Refactor and extend PluginTransactionPoolValidatorService #6636
fab-10
merged 5 commits into
hyperledger:main
from
fab-10:txpool-validator-service-refactor-extend
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
txpool-validator-service-refactor-extend
branch
from
February 28, 2024 19:31
db73383
to
1ab0bac
Compare
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
txpool-validator-service-refactor-extend
branch
from
February 29, 2024 15:02
7fca6f8
to
8581c4d
Compare
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
txpool-validator-service-refactor-extend
branch
from
February 29, 2024 15:31
8581c4d
to
94bdfaf
Compare
siladu
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much input from a plugin system point of view, but generally looks good 👍
# Conflicts: # CHANGELOG.md # acceptance-tests/dsl/src/main/java/org/hyperledger/besu/tests/acceptance/dsl/node/ThreadBesuNodeRunner.java
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Mar 5, 2024
…r#6636) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Mar 8, 2024
…r#6636) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
…r#6636) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: amsmota <[email protected]>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
…r#6636) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: amsmota <[email protected]>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
…r#6636) Signed-off-by: Fabio Di Fabio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Most advanced CI tests are deferred until PR approval, but you could:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests
PR description
This PR extends the transaction pool validator plugin, to also pass the
isLocal
andhasPriority
attributes of the tx to validateThen a renaming has been done, for making clear that this validator service only apply when adding a tx to the transaction pool, and not when doing other validations, like during block import, along with a refactor to align this service to the way TransactionSelectorService is managed.
Fixed Issue(s)