Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent startup if PoA and snap/checkpoint #6625

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Feb 28, 2024

Fixes #6385

Docs - can't see anywhere in the docs where we mention snap or checkpoint on the private networks side, but may be worth adding an explicit note that you must use FAST or FULL if using BFT consensus.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • locally run all unit tests via: ./gradlew build
  • locally run all acceptance tests via: ./gradlew acceptanceTest
  • locally run all integration tests via: ./gradlew integrationTest
  • locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

PR description

Fixed Issue(s)

Signed-off-by: Sally MacFarlane <[email protected]>
Copy link
Contributor

@matthew1001 matthew1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @macfarla, looks good to me, will help avoid confusion.

@macfarla macfarla added the doc-change-required Indicates an issue or PR that requires doc to be updated label Feb 29, 2024
@macfarla macfarla enabled auto-merge (squash) February 29, 2024 04:49
@macfarla macfarla merged commit e3e512d into hyperledger:main Feb 29, 2024
52 of 55 checks passed
@macfarla macfarla mentioned this pull request Mar 3, 2024
8 tasks
@joaniefromtheblock joaniefromtheblock removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Mar 7, 2024
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
* don't start if PoA and snap/checkpoint

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: amsmota <[email protected]>
amsmota pushed a commit to Citi/besu that referenced this pull request Apr 16, 2024
* don't start if PoA and snap/checkpoint

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: amsmota <[email protected]>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
* don't start if PoA and snap/checkpoint

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla deleted the snap-bft-no branch July 12, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

behave better if BFT and SNAP specified
3 participants