Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Move api options to its own class #6512

Merged

Conversation

Gabriel-Trintinalia
Copy link
Contributor

PR description

Move api options options to its own class

Fixed Issue(s)

see #6428

Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Copy link

github-actions bot commented Feb 1, 2024

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests
  • I thought about running CI.
  • If I did not run CI, I ran as much locally as possible before pushing.

Signed-off-by: Gabriel-Trintinalia <[email protected]>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel-Trintinalia Gabriel-Trintinalia enabled auto-merge (squash) February 1, 2024 06:50
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit b68ee44 into hyperledger:main Feb 1, 2024
24 checks passed
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the 6428-api-options branch January 23, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants