Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target to use about 25MB for the new layered txpool by default #5974

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Oct 2, 2023

PR description

Reduce the default memory usage of the txpool, to limit the added amount of memory used by Besu.
There 2 memory limited layers, ready and sparse, so to target 25MB we set the limit for a layer to 12.5MB

fixes #5977

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reckon this warrants a changelog entry?

@fab-10
Copy link
Contributor Author

fab-10 commented Oct 3, 2023

waiting for more metrics before merging

Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Copy link
Contributor Author

fab-10 commented Oct 3, 2023

Reckon this warrants a changelog entry?

Existing changelog entry about the layered txpool, updated

@fab-10 fab-10 merged commit 7ee5b73 into hyperledger:main Oct 3, 2023
8 checks passed
@fab-10 fab-10 deleted the lower-layered-txpool-defaults branch October 3, 2023 18:15
jflo pushed a commit to jflo/besu that referenced this pull request Nov 10, 2023
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tuned default values for the layered tx pool that respect memory constraints
2 participants