Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added toString implementation for TransactionSimulatorResult #5957

Conversation

Shritesh99
Copy link
Contributor

PR description

Added toString implementation for TransactionSimulatorResult

Fixed Issue(s)

fix #5942

@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla
Copy link
Contributor

Thanks for your contribution @Shritesh99 !

@macfarla macfarla enabled auto-merge (squash) September 29, 2023 01:05
+ transaction
+ ", "
+ "result="
+ result

Check notice

Code scanning / CodeQL

Use of default toString() Note

Default toString(): TransactionProcessingResult inherits toString() from Object, and so is not suitable for printing.
@macfarla macfarla merged commit e7311f0 into hyperledger:main Sep 29, 2023
8 checks passed
@Shritesh99 Shritesh99 deleted the 5942-toString-implementation-for-TransactionSimulatorResult branch September 29, 2023 15:53
jflo pushed a commit to jflo/besu that referenced this pull request Nov 10, 2023
…dger#5957)

Signed-off-by: Shritesh <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a toString implementation for TransactionSimulatorResult
2 participants