Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forkchoice v2 hive tests #5949

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

jflo
Copy link
Contributor

@jflo jflo commented Sep 26, 2023

re-arranges validations so the failures occurr when hive expects them to.

@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 41e829b into hyperledger:main Sep 27, 2023
9 checks passed
jflo added a commit to jflo/besu that referenced this pull request Nov 10, 2023
* payload validation moved earlier, fcu v2 checks for cancun timestamps

Signed-off-by: Justin Florentine <[email protected]>

* payload validation moved earlier, fcu v2 checks for cancun timestamps

Signed-off-by: Justin Florentine <[email protected]>

* build passes

Signed-off-by: Justin Florentine <[email protected]>

---------

Signed-off-by: Justin Florentine <[email protected]>
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
* payload validation moved earlier, fcu v2 checks for cancun timestamps

Signed-off-by: Justin Florentine <[email protected]>

* payload validation moved earlier, fcu v2 checks for cancun timestamps

Signed-off-by: Justin Florentine <[email protected]>

* build passes

Signed-off-by: Justin Florentine <[email protected]>

---------

Signed-off-by: Justin Florentine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants