Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds Matthew Whitehead as a maintainer #5876

Merged
merged 9 commits into from
Sep 26, 2023
Merged

adds Matthew Whitehead as a maintainer #5876

merged 9 commits into from
Sep 26, 2023

Conversation

jflo
Copy link
Contributor

@jflo jflo commented Sep 13, 2023

I propose to add @matthew1001 as a Besu project maintainer.

@matthew1001 contributed with many high quality commits:

  • has implemented new JSON-RPC api endpoints, per execution api specs
  • has improved error reporting in apis
  • has improved configurability for non PoS networks

Here are their past contributions on Besu project.

Voting ends two weeks from today.

For more information on this process see the Becoming a Maintainer section in the MAINTAINERS.md file.

@jflo jflo marked this pull request as ready for review September 13, 2023 17:21
@github-actions
Copy link

github-actions bot commented Sep 13, 2023 •
edited by jflo
Loading

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

macfarla
macfarla approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contributions @matthew1001 !

siladu
siladu approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

(nbd, but I think the new entry maybe should go underneath macfarla?)

@macfarla
Copy link
Contributor

🎉

(nbd, but I think the new entry maybe should go underneath macfarla?)

good catch - that's why we need 12 approvals on these PRs... and actually now that I have my fine-toothed comb out - alphabetically - should be below matkt

garyschulte
garyschulte approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

usmansaleem
usmansaleem approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@macfarla macfarla enabled auto-merge (squash) September 26, 2023 00:52
@macfarla macfarla merged commit d7a831e into hyperledger:main Sep 26, 2023
6 checks passed
jflo added a commit to jflo/besu that referenced this pull request Nov 10, 2023
@jflo @macfarla
adds Matthew Whitehead as a maintainer (hyperledger#5876)
7303ecf 
* adds Matthew Whitehead as a maintainer

* alphabetizes list by github id

Signed-off-by: Justin Florentine <[email protected]>

---------

Signed-off-by: Justin Florentine <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
@jflo @macfarla @NickSneo
adds Matthew Whitehead as a maintainer (hyperledger#5876)
0539534 
* adds Matthew Whitehead as a maintainer

* alphabetizes list by github id

Signed-off-by: Justin Florentine <[email protected]>

---------

Signed-off-by: Justin Florentine <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matkt matkt matkt approved these changes

@gfukushima gfukushima gfukushima approved these changes

@pinges pinges pinges approved these changes

@Gabriel-Trintinalia Gabriel-Trintinalia Gabriel-Trintinalia approved these changes

@daniellehrner daniellehrner daniellehrner approved these changes

@usmansaleem usmansaleem usmansaleem approved these changes

@siladu siladu siladu approved these changes

@macfarla macfarla macfarla approved these changes

@lucassaldanha lucassaldanha lucassaldanha approved these changes

@garyschulte garyschulte garyschulte approved these changes

@jframe jframe jframe approved these changes

@fab-10 fab-10 fab-10 approved these changes

@ahamlat ahamlat ahamlat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.