-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make docker commands easier to debug during upload and manifest creation #5522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Dudley <[email protected]>
|
Signed-off-by: Simon Dudley <[email protected]>
siladu
changed the title
Print docker commands during upload and manifest creation
Make docker commands easier to debug during upload and manifest creation
May 31, 2023
macfarla
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
garyschulte
approved these changes
May 31, 2023
jframe
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
siladu
added a commit
to siladu/besu
that referenced
this pull request
Jun 1, 2023
…ion (hyperledger#5522) - Print docker commands during upload and manifest creation - Separate out docker push and docker manifest push commands for release Signed-off-by: Simon Dudley <[email protected]>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
…ion (hyperledger#5522) - Print docker commands during upload and manifest creation - Separate out docker push and docker manifest push commands for release Signed-off-by: Simon Dudley <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…ion (hyperledger#5522) - Print docker commands during upload and manifest creation - Separate out docker push and docker manifest push commands for release Signed-off-by: Simon Dudley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging for #5521
Print out commands being executed
Separate out docker push and docker manifest push commands for release to make it easier to spot which one fails in #5521