Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docker commands easier to debug during upload and manifest creation #5522

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

siladu
Copy link
Contributor

@siladu siladu commented May 31, 2023

Debugging for #5521

Print out commands being executed

Separate out docker push and docker manifest push commands for release to make it easier to spot which one fails in #5521

@github-actions
Copy link

github-actions bot commented May 31, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@siladu siladu requested review from garyschulte and jframe May 31, 2023 22:53
@siladu siladu changed the title Print docker commands during upload and manifest creation Make docker commands easier to debug during upload and manifest creation May 31, 2023
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siladu siladu added the TeamGroot GH issues worked on by Groot Team label May 31, 2023
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siladu siladu merged commit a5a2a41 into hyperledger:main Jun 1, 2023
siladu added a commit to siladu/besu that referenced this pull request Jun 1, 2023
…ion (hyperledger#5522)

- Print docker commands during upload and manifest creation
- Separate out docker push and docker manifest push commands for release

Signed-off-by: Simon Dudley <[email protected]>
@siladu siladu deleted the docker-release-logging branch June 2, 2023 10:10
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
…ion (hyperledger#5522)

- Print docker commands during upload and manifest creation
- Separate out docker push and docker manifest push commands for release

Signed-off-by: Simon Dudley <[email protected]>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…ion (hyperledger#5522)

- Print docker commands during upload and manifest creation
- Separate out docker push and docker manifest push commands for release

Signed-off-by: Simon Dudley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TeamGroot GH issues worked on by Groot Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants