Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction pool flag to disable specific behaviors for locally submitted transactions #5418

Merged
merged 7 commits into from
May 5, 2023

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented May 2, 2023

PR description

Setting the option tx-pool-disable-locals transactions submitted via API eth_sendrawtransaction do not receive a special treatment and are validated like any remote transactions, and are not prioritized over remote transactions.

Fixed Issue(s)

@fab-10 fab-10 added the doc-change-required Indicates an issue or PR that requires doc to be updated label May 2, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. couple of nits

fab-10 and others added 2 commits May 5, 2023 10:48
@fab-10 fab-10 enabled auto-merge (squash) May 5, 2023 08:59
@fab-10 fab-10 merged commit 64c422b into hyperledger:main May 5, 2023
@fab-10 fab-10 deleted the txpool-nolocals branch May 5, 2023 10:42
@bgravenorst bgravenorst removed the doc-change-required Indicates an issue or PR that requires doc to be updated label May 14, 2023
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
…tted transactions (hyperledger#5418)

* Transaction pool flag to disable special handling of locally submitted transactions

Signed-off-by: Fabio Di Fabio <[email protected]>

* Update CHANGELOG

Signed-off-by: Fabio Di Fabio <[email protected]>

* Fix options and more tests

Signed-off-by: Fabio Di Fabio <[email protected]>

* Update besu/src/main/java/org/hyperledger/besu/cli/options/unstable/TransactionPoolOptions.java

Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>

---------

Signed-off-by: Fabio Di Fabio <[email protected]>
Co-authored-by: Stefan Pingel <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…tted transactions (hyperledger#5418)

* Transaction pool flag to disable special handling of locally submitted transactions

Signed-off-by: Fabio Di Fabio <[email protected]>

* Update CHANGELOG

Signed-off-by: Fabio Di Fabio <[email protected]>

* Fix options and more tests

Signed-off-by: Fabio Di Fabio <[email protected]>

* Update besu/src/main/java/org/hyperledger/besu/cli/options/unstable/TransactionPoolOptions.java

Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>

---------

Signed-off-by: Fabio Di Fabio <[email protected]>
Co-authored-by: Stefan Pingel <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants