Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump max rpc batch size to 1024 #5108

Merged
merged 1 commit into from
Feb 17, 2023
Merged

bump max rpc batch size to 1024 #5108

merged 1 commit into from
Feb 17, 2023

Conversation

garyschulte
Copy link
Contributor

PR description

Prysm CL appears to request headers in batches of 1001 rather than 1k. Bump default max batch size to 1024

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Acceptance Tests (Non Mainnet)

  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.

Changelog

@garyschulte
bump to 1024
f1602be 
Signed-off-by: garyschulte <[email protected]>
siladu
siladu approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garyschulte garyschulte enabled auto-merge (squash) February 17, 2023 06:55
jframe
jframe approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garyschulte garyschulte merged commit 79c1a97 into hyperledger:release-23.1.x Feb 17, 2023
siladu pushed a commit to siladu/besu that referenced this pull request Feb 20, 2023
@garyschulte @siladu
bump to 1024 (hyperledger#5108)
964b6c1 
Signed-off-by: garyschulte <[email protected]>
@siladu siladu mentioned this pull request Feb 20, 2023
Merged
siladu added a commit that referenced this pull request Feb 20, 2023
@siladu
bump to 1024 (#5108) (#5114)
bac7ade 
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
@bgravenorst bgravenorst mentioned this pull request Feb 28, 2023
Closed
1 task
ensi321 pushed a commit to ensi321/besu that referenced this pull request Mar 6, 2023
@siladu @ensi321
bump to 1024 (hyperledger#5108) (hyperledger#5114)
b96a7d6 
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@siladu @elenduuche
bump to 1024 (hyperledger#5108) (hyperledger#5114)
25a877c 
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
@siladu siladu mentioned this pull request Oct 18, 2023
Closed
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@siladu @eum602
bump to 1024 (hyperledger#5108) (hyperledger#5114)
348f3a6 
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
@garyschulte garyschulte deleted the feature/batch-size-reprise branch January 24, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garyschulte @jframe @siladu