Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIE-2322] Create file if logBloom-current.cache is missing #438

Merged

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Mar 2, 2020

Signed-off-by: Karim TAAM [email protected]

PR description

Contract used : Deposit contract for the prysm testnet on Goerli

0x4689a3C63CE249355C8a573B5974db21D2d1b8Ef

Topics used : keccack('DepositEvent(bytes,bytes,bytes,bytes,bytes)') = 649bbc62d0e31342afea4e5cd82d4049e7e1ee912fc0889aa790803be39038c5

A bug seems to be present in BESU . In the case where a node was already synchronized without cache and that we activate it thereafter

In case we activate the cache of a node already synchronized. BESU must cache all the blocks already present in the database.

But after waiting for caching to finish we don't get the right result with eth_getLogs

curl --location --request POST 'http://localhost:8545' \
--header 'Content-Type: text/plain' \
--data-raw '{"jsonrpc":"2.0","method":"eth_getLogs","params":[{"fromBlock":"earliest", "toBlock":"latest", "address":"0x4689a3C63CE249355C8a573B5974db21D2d1b8Ef", "topics":["0x649bbc62d0e31342afea4e5cd82d4049e7e1ee912fc0889aa790803be39038c5"]}], "id":1}'

Here is the comparison of eth_getLogs responses

  • Node without cache 71.49 MB
  • Node with cache activated from the beginning 71.49 MB
  • Node with cache activated after a full synchronization 66.49 MB

We can see a difference in the response when BESU tries to cache blocks already in the database

Let's see where is the difference between the two responses :

diff response_witout_cache.json response_cache_activated_after.json

We can see that it is the last blocks near the head (2274293) that are missing in the answer.

430080a430081,462480
>   \}, \{\
>     "logIndex" : "0x0",\
>     "removed" : false,\
>     "blockNumber" : "0x219533",\
>     "blockHash" : "0x56142a3f5663fd7618fb224edd92f6c6e449b29c5758a4f4d5cb3ba9f7898928",\
>     "transactionHash" : "0x1ec3717420395a6340217a07b6c53115145b475b4c5a3f0d63e1410107e69211",\
>     "transactionIndex" : "0x4",\
>     "address" : "0x4689a3c63ce249355c8a573b5974db21d2d1b8ef",\
>     "data" : "0x00000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000001400000000000000000000000000000000000000000000000000000000000000180000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000308e46cd0296acde66c9d1f2addf1e4eb651e39580715bf814bcc36ee6e77d625061c95090e56e37d38b3edc24a328da3900000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000181636ad47e485b8603a9d4bb1ca1af02304b79f55e0cdad74e88c2da31acd00000000000000000000000000000000000000000000000000000000000000080020bcbe0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000608b7f5ef1ef9071d96c8fe674bac88c9dd76f2d0cd3026dd4276a2d38525e35dc14919acbed479213a5a163502294b6900132b5388befdb67862ae743224f9be918cd1195d8b7ac8561beff4a46aaa13166ceea04d1f2fff33a6bd4e8303859d00000000000000000000000000000000000000000000000000000000000000008ffa7000000000000000000000000000000000000000000000000000000000000",\
>     "topics" : [ "0x649bbc62d0e31342afea4e5cd82d4049e7e1ee912fc0889aa790803be39038c5" ]\
>   \}, \{\
>     "logIndex" : "0x0",\
>     "removed" : false,\
>     "blockNumber" : "0x219657",\
>     "blockHash" : "0x78d63e413eea543538a206995f838593370b1764bfbebe904ac895d498a96614",\
>     "transactionHash" : "0xf6b1435bcc0ba7083b70047af5577e75fa8781794844496b9cd7b36a3aa57aeb",\
>     "transactionIndex" : "0x2",\
>     "address" : "0x4689a3c63ce249355c8a573b5974db21d2d1b8ef",\
>     "data" : "0x00000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000001400000000000000000000000000000000000000000000000000000000000000180000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000309113631fe831ef0133345359fa764caaa69582b1095471016079ac84d7f4b2a51ef366c4001178f324854fa40b17cfbb000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000020002f6391ef571d5eda8d8f9de626a475c7fdab7e5223d89b5db11dc45de3bd6000000000000000000000000000000000000000000000000000000000000000080020bcbe000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000060a43d88c91d066e2b6182622dd07190f9162e6478bccfb585246dda997d2b0a63148576aa4611bc96eaa8e52afdaa888209f130e55a48c7996c48b6b8a3d7094fed34a3ed7431f8a35d023d329883fe5efe92b18f7c58299bf795524c936bd34b000000000000000000000000000000000000000000000000000000000000000800a8000000000000000000000000000000000000000000000000000000000000",\
>     "topics" : [ "0x649bbc62d0e31342afea4e5cd82d4049e7e1ee912fc0889aa790803be39038c5" ]\
>   \}
>   ...
>   \{\
>     "logIndex" : "0x0",\
>     "removed" : false,\
>     "blockNumber" : "0x22b399",\
>     "blockHash" : "0x6d1b72c82e3d1eecccc89c3f83d20ceed51fe4724d042479670d19a581e7cc66",\
>     "transactionHash" : "0x96e4db457be12fc96ffeeaca12663712e010686f6d797f81e5602b4ff5534181",\
>     "transactionIndex" : "0x2",\
>     "address" : "0x4689a3c63ce249355c8a573b5974db21d2d1b8ef",\
>     "data" : "0x00000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000140000000000000000000000000000000000000000000000000000000000000018000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000030a2ff5d78057c6671838f0d9657b738becf4b5c2c886d2e59631e39e70ce84927b4d881338aaca00f20eb127f4bce51cc00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000a7c068a64f307026a657ef72bfb05edad6d1dfb25da4e2d5693506916abaab00000000000000000000000000000000000000000000000000000000000000080020bcbe0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000608c15dfc1b09bf0834fbc46960ed742b059ae2f40650993a6f9887ec06a6c57fb0abe097637b214f03b02519991d3e1c8073dee269454e011aba5b9a9c22306ca879dfc986d66a440068a2dcb1d3624284228c73e0625287085295290fbd484fe0000000000000000000000000000000000000000000000000000000000000008a6b4000000000000000000000000000000000000000000000000000000000000",\
>     "topics" : [ "0x649bbc62d0e31342afea4e5cd82d4049e7e1ee912fc0889aa790803be39038c5" ]\

However we can see that BESU had finished block caching (with an exception)

karimtaam@mbp-de-karim-1 bin % ./besu --network=goerli --auto-log-bloom-caching-enabled=true --fast-sync-min-peers=3 --sync-mode=FAST --p2p-port=30303 --rpc-http-enabled --rpc-http-api="CLIQUE,ADMIN,ETH,NET,WEB3,IBFT,PERM,DEBUG,MINER,EEA,PRIV" --data-path=/Users/karimtaam/network/goerli2 --graphql-http-enabled
Setting logging level to INFO
2020-03-02 12:25:31.441+01:00 | main | INFO  | Besu | Starting Besu version: besu/v1.4.1-dev-cf896061/osx-x86_64/adoptopenjdk-java-13
2020-03-02 12:25:31.587+01:00 | main | WARN  | Besu | Permissions are disabled. Cannot enable PERM APIs when not using Permissions.
2020-03-02 12:25:31.588+01:00 | main | INFO  | StaticNodesParser | StaticNodes file /Users/karimtaam/network/goerli2/static-nodes.json does not exist, no static connections will be created.
2020-03-02 12:25:31.588+01:00 | main | INFO  | Besu | Connecting to 0 static nodes.
2020-03-02 12:25:32.103+01:00 | main | INFO  | KeyPairUtil | Loaded key 0x7fc8919360b2df040323882fd1b5765723e19816ba43343c3be9ab0c8336be653d674b81a10419424b94995696a60658689bd545e3fdd72b54cfb77da4a598d5 from /Users/karimtaam/network/goerli2/key
2020-03-02 12:25:32.105+01:00 | main | WARN  | Besu | Privacy is disabled. Cannot use EEA/PRIV API methods when not using Privacy.
2020-03-02 12:25:32.120+01:00 | main | INFO  | DatabaseMetadata | Lookup database metadata file in data directory: /Users/karimtaam/network/goerli2
2020-03-02 12:25:32.158+01:00 | main | INFO  | RocksDBKeyValueStorageFactory | Existing database detected at /Users/karimtaam/network/goerli2. Version 1
2020-03-02 12:25:33.472+01:00 | main | INFO  | ProtocolScheduleBuilder | Protocol schedule created with milestones: [ConstantinopleFix: 0, Istanbul: 1561651]
2020-03-02 12:25:33.603+01:00 | main | INFO  | FastDownloaderFactory | Fast sync was requested, but cannot be enabled because the local blockchain is not empty.
2020-03-02 12:25:33.615+01:00 | main | INFO  | RunnerBuilder | Detecting NAT service.
2020-03-02 12:25:33.936+01:00 | main | INFO  | Runner | Starting Ethereum main loop ...
2020-03-02 12:25:33.936+01:00 | main | INFO  | NatService | No NAT environment detected so no service could be started
2020-03-02 12:25:33.936+01:00 | main | INFO  | NetworkRunner | Starting Network.
2020-03-02 12:25:34.020+01:00 | nioEventLoopGroup-2-1 | INFO  | RlpxAgent | P2P RLPx agent started and listening on /0:0:0:0:0:0:0:0:30303.
2020-03-02 12:25:34.021+01:00 | main | INFO  | PeerDiscoveryAgent | Starting peer discovery agent on host=0.0.0.0, port=30303
2020-03-02 12:25:34.063+01:00 | vert.x-eventloop-thread-1 | INFO  | VertxPeerDiscoveryAgent | Started peer discovery agent successfully, on effective host=0:0:0:0:0:0:0:0 and port=30303
2020-03-02 12:25:34.064+01:00 | vert.x-eventloop-thread-1 | INFO  | PeerDiscoveryAgent | P2P peer discovery agent started and listening on /0:0:0:0:0:0:0:0:30303
2020-03-02 12:25:34.098+01:00 | main | INFO  | DefaultP2PNetwork | Enode URL enode://7fc8919360b2df040323882fd1b5765723e19816ba43343c3be9ab0c8336be653d674b81a10419424b94995696a60658689bd545e3fdd72b54cfb77da4a598d5@127.0.0.1:30303
2020-03-02 12:25:34.100+01:00 | main | INFO  | DefaultSynchronizer | Starting synchronizer.
2020-03-02 12:25:34.101+01:00 | main | INFO  | Pruner | Starting Pruner.
2020-03-02 12:25:37.216+01:00 | main | INFO  | FullSyncDownloader | Start full sync.
2020-03-02 12:25:37.223+01:00 | main | INFO  | JsonRpcHttpService | Starting JsonRPC service on 127.0.0.1:8545
2020-03-02 12:25:37.250+01:00 | vert.x-eventloop-thread-5 | INFO  | JsonRpcHttpService | JsonRPC service started and listening on 127.0.0.1:8545
2020-03-02 12:25:37.250+01:00 | main | INFO  | GraphQLHttpService | Starting GraphQL HTTP service on 127.0.0.1:8547
2020-03-02 12:25:37.253+01:00 | vert.x-eventloop-thread-7 | INFO  | GraphQLHttpService | GraphQL HTTP service started and listening on 127.0.0.1:8547
2020-03-02 12:25:37.254+01:00 | main | INFO  | Runner | Ethereum main loop is up.
2020-03-02 12:25:37.258+01:00 | main | INFO  | AutoTransactionLogBloomCachingService | Starting auto transaction log bloom caching service.
2020-03-02 12:25:37.320+01:00 | nioEventLoopGroup-3-1 | INFO  | SyncTargetManager | Found common ancestor with peer 0x46add44b9f13965f7b... at block 2274453
2020-03-02 12:25:39.908+01:00 | nioEventLoopGroup-3-1 | INFO  | BlockPropagationManager | Saving announced block 2274469 (0x54244e6465020c2d8fbfd6aef77cc2dd894c922225bbe1d64035ba2d284db30c) for future import
2020-03-02 12:25:41.224+01:00 | EthScheduler-Computation-1 | ERROR | TransactionLogBloomCacher | Unhandled caching exception.
java.nio.file.NoSuchFileException: /Users/karimtaam/network/goerli2/caches/logBloom-current.cache -> /Users/karimtaam/network/goerli2/caches/logBloom-22.cache
at sun.nio.fs.UnixException.translateToIOException(UnixException.java:92) ~[?:?]
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111) ~[?:?]
at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:417) ~[?:?]
at sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:267) ~[?:?]
at java.nio.file.Files.move(Files.java:1425) ~[?:?]
at org.hyperledger.besu.ethereum.api.query.TransactionLogBloomCacher.populateLatestSegment(TransactionLogBloomCacher.java:184) ~[besu-api-1.4.1-SNAPSHOT.jar:1.4.1-dev-cf896061]
at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1771) [?:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
at java.lang.Thread.run(Thread.java:830) [?:?]
2020-03-02 12:25:41.225+01:00 | EthScheduler-Computation-4 | ERROR | TransactionLogBloomCacher | Unhandled caching exception.
java.nio.file.NoSuchFileException: /Users/karimtaam/network/goerli2/caches/logBloom-current.cache -> /Users/karimtaam/network/goerli2/caches/logBloom-22.cache
at sun.nio.fs.UnixException.translateToIOException(UnixException.java:92) ~[?:?]
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111) ~[?:?]
at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:417) ~[?:?]
at sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:267) ~[?:?]
at java.nio.file.Files.move(Files.java:1425) ~[?:?]
at org.hyperledger.besu.ethereum.api.query.TransactionLogBloomCacher.populateLatestSegment(TransactionLogBloomCacher.java:184) ~[besu-api-1.4.1-SNAPSHOT.jar:1.4.1-dev-cf896061]
at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1771) [?:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
at java.lang.Thread.run(Thread.java:830) [?:?]
2020-03-02 12:25:41.225+01:00 | EthScheduler-Computation-0 | ERROR | TransactionLogBloomCacher | Unhandled caching exception.
java.nio.file.NoSuchFileException: /Users/karimtaam/network/goerli2/caches/logBloom-current.cache -> /Users/karimtaam/network/goerli2/caches/logBloom-22.cache
at sun.nio.fs.UnixException.translateToIOException(UnixException.java:92) ~[?:?]
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111) ~[?:?]
at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:417) ~[?:?]
at sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:267) ~[?:?]
at java.nio.file.Files.move(Files.java:1425) ~[?:?]
at org.hyperledger.besu.ethereum.api.query.TransactionLogBloomCacher.populateLatestSegment(TransactionLogBloomCacher.java:184) ~[besu-api-1.4.1-SNAPSHOT.jar:1.4.1-dev-cf896061]
at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1771) [?:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
at java.lang.Thread.run(Thread.java:830) [?:?]
2020-03-02 12:25:41.225+01:00 | EthScheduler-Computation-3 | ERROR | TransactionLogBloomCacher | Unhandled caching exception.
java.nio.file.NoSuchFileException: /Users/karimtaam/network/goerli2/caches/logBloom-current.cache -> /Users/karimtaam/network/goerli2/caches/logBloom-22.cache
at sun.nio.fs.UnixException.translateToIOException(UnixException.java:92) ~[?:?]
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111) ~[?:?]
at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:417) ~[?:?]
at sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:267) ~[?:?]
at java.nio.file.Files.move(Files.java:1425) ~[?:?]
at org.hyperledger.besu.ethereum.api.query.TransactionLogBloomCacher.populateLatestSegment(TransactionLogBloomCacher.java:184) ~[besu-api-1.4.1-SNAPSHOT.jar:1.4.1-dev-cf896061]
at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1771) [?:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
at java.lang.Thread.run(Thread.java:830) [?:?]
2020-03-02 12:25:42.726+01:00 | EthScheduler-Services-5 (importBlock) | INFO  | AbstractMiningCoordinator | Resuming mining operations
2020-03-02 12:25:43.132+01:00 | EthScheduler-Computation-6 | ERROR | TransactionLogBloomCacher | Unhandled caching exception.
java.nio.file.NoSuchFileException: /Users/karimtaam/network/goerli2/caches/logBloom-current.cache -> /Users/karimtaam/network/goerli2/caches/logBloom-22.cache
at sun.nio.fs.UnixException.translateToIOException(UnixException.java:92) ~[?:?]
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111) ~[?:?]
at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:417) ~[?:?]
at sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:267) ~[?:?]
at java.nio.file.Files.move(Files.java:1425) ~[?:?]
at org.hyperledger.besu.ethereum.api.query.TransactionLogBloomCacher.populateLatestSegment(TransactionLogBloomCacher.java:184) ~[besu-api-1.4.1-SNAPSHOT.jar:1.4.1-dev-cf896061]
at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1771) [?:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
at java.lang.Thread.run(Thread.java:830) [?:?]
2020-03-02 12:25:51.206+01:00 | nioEventLoopGroup-3-1 | INFO  | SyncTargetManager | Found common ancestor with peer 0x46add44b9f13965f7b... at block 2274467
2020-03-02 12:25:52.872+01:00 | EthScheduler-Workers-0 | INFO  | BlockPropagationManager | Imported 1 pending blocks
2020-03-02 12:25:55.584+01:00 | EthScheduler-Workers-1 | INFO  | BlockPropagationManager | Imported #2,274,470 / 1 tx / 0 om / 3,235,465 (40.4%) gas / (0xfdd66d6dc62ee12ff76673bca5f7087ca573fb543bed626123d94b21cf0548b9) in 0.005s.
2020-03-02 12:26:10.850+01:00 | EthScheduler-Workers-3 | INFO  | BlockPropagationManager | Imported #2,274,471 / 0 tx / 0 om / 0 (0.0%) gas / (0xa49748fb4c845f51c2a72be8490956c74fa2429f8b31feb9b9c9bcaae0c3f9e3) in 0.001s.
2020-03-02 12:26:15.866+01:00 | EthScheduler-Workers-2 | INFO  | BlockPropagationManager | Imported #2,274,471 / 5 tx / 0 om / 917,459 (11.5%) gas / (0xc3ba2e80a01da4b97c3e16caa4a4cd11830daac003530aac6a9c82b99d54a2fd) in 1.725s.
2020-03-02 12:26:24.398+01:00 | EthScheduler-Workers-1 | INFO  | BlockPropagationManager | Imported #2,274,472 / 2 tx / 0 om / 469,316 (5.9%) gas / (0xc15038550e7d3e5f349701def41581860cd9e4adbf3d76bac34abfeabe07ceb3) in 0.012s.
2020-03-02 12:26:25.801+01:00 | EthScheduler-Workers-3 | INFO  | BlockPropagationManager | Imported #2,274,472 / 0 tx / 0 om / 0 (0.0%) gas / (0xd0d8e5f942a1cc0411f3f8c7fc037a36dcca3f8f5eb5a2327c930d82d6bb9d0e) in 0.001s.
2020-03-02 12:26:38.265+01:00 | EthScheduler-Timer-0 | INFO  | TransactionLogBloomCacher | Generating transaction log bloom cache from block 2100000 to block 2200000 in /Users/karimtaam/network/goerli2/caches
2020-03-02 12:26:38.266+01:00 | EthScheduler-Timer-0 | INFO  | TransactionLogBloomCacher | Caching segment at 2100000
2020-03-02 12:26:39.763+01:00 | EthScheduler-Workers-0 | INFO  | BlockPropagationManager | Imported #2,274,473 / 2 tx / 0 om / 375,248 (4.7%) gas / (0x74891a8eb6533bddb912aec6c05095d3d424278f79355be8b8de981c3be3ef59) in 0.005s.
2020-03-02 12:26:41.191+01:00 | EthScheduler-Timer-0 | INFO  | TransactionLogBloomCacher | Caching request complete
2020-03-02 12:26:41.191+01:00 | EthScheduler-Timer-0 | INFO  | TransactionLogBloomCacher | Generating transaction log bloom cache from block 2000000 to block 2100000 in /Users/karimtaam/network/goerli2/caches
2020-03-02 12:26:41.191+01:00 | EthScheduler-Timer-0 | INFO  | TransactionLogBloomCacher | Caching segment at 2000000
2020-03-02 12:26:44.657+01:00 | EthScheduler-Timer-0 | INFO  | TransactionLogBloomCacher | Caching request complete
....
2020-03-02 12:28:02.218+01:00 | EthScheduler-Timer-0 | INFO  | TransactionLogBloomCacher | Caching segment at 100000
2020-03-02 12:28:06.635+01:00 | EthScheduler-Timer-0 | INFO  | TransactionLogBloomCacher | Caching request complete

Fixed Issue(s)

Create file if logBloom-current.cache is missing

@shemnon
Copy link
Contributor

shemnon commented Mar 2, 2020

So with this patch you observe we get all the data?

@matkt
Copy link
Contributor Author

matkt commented Mar 2, 2020

So with this patch you observe we get all the data?

yes with this patch the last blocks are well included and the result corresponds to the other calls

@AbdelStark AbdelStark merged commit 9c576cc into hyperledger:master Mar 3, 2020
@matkt matkt mentioned this pull request Mar 12, 2020
@matkt matkt deleted the feature/pie-2322-missing-block-with-cache branch March 19, 2020 14:45
siladu pushed a commit to siladu/besu that referenced this pull request Oct 28, 2024
* eth: add eth_getBlockReceipts

Signed-off-by: jsvisa <[email protected]>

Signed-off-by: jsvisa <[email protected]>

* eth: blockReceipts

Signed-off-by: jsvisa <[email protected]>

* getBlockReceipts maybe null

Signed-off-by: jsvisa <[email protected]>

* tests: add eth_getBlockReceipts

Signed-off-by: jsvisa <[email protected]>

---------

Signed-off-by: jsvisa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants