-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alternative malloc implementation - jemalloc #4126
Merged
garyschulte
merged 6 commits into
hyperledger:main
from
garyschulte:feature/use_jemalloc
Jul 19, 2022
Merged
alternative malloc implementation - jemalloc #4126
garyschulte
merged 6 commits into
hyperledger:main
from
garyschulte:feature/use_jemalloc
Jul 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add jemalloc preload to besu startup add jemalloc lib download to docker jvm images Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…as disallowed all DYLD_* envars for security Signed-off-by: garyschulte <[email protected]>
jflo
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but maybe add a line for this in the CHANGELOG.md, people will be psyched for this.
Signed-off-by: garyschulte <[email protected]>
Amazing work on this all involved! Thank you!!!! |
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* add malloc arena params to besu startup * add jemalloc preload to besu startup * add jemalloc lib download to docker jvm images * use 5.* for jemalloc-dev version * add jemalloc to circleci containers for acceptance tests Signed-off-by: garyschulte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Use jemalloc with linux runtimes to better manage rocksdb memory usage.
smoke tested and verified working on:
Linux x86_64
Docker linux aarch64 (on OSX M1)
Native OSX (El Capitan +) is not loading jemalloc currently
Fixed Issue(s)
potentially addresses:
#4057
Documentation
If we end up going with jemalloc as an alternative malloc implementation for besu, we should document the need to have jemalloc installed in your environment, how to do it for each platform.
doc-change-required
label to this PR ifupdates are required.
Changelog