Update SLOAD_GAS cost to 200 in Aztlan Gas Calculator (#23) #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change SLOAD_GAS cost in Aztlan Gas Calculator from 800 to 200 and update functions that use SLOAD_GAS. Signed-off-by: edwardmack <[email protected]>
Change SLOAD_GAS cost in Aztlan Gas Calculator from 800 to 200 and update functions that use SLOAD_GAS. Signed-off-by: edwardmack <[email protected]> Signed-off-by: Edward Mack <[email protected]>
… into ed/etc_update_sload
shemnon
approved these changes
Feb 11, 2020
|
We're putting this on |
|
Official specification: ethereumclassic/ECIPs#293 |
|
Should ECIP-1086 be accepted, we will merge this. |
removed overrides of calculateStorageCost and calculateStorageRefundAmount in AztlanGasCalculator because these were causing aztlan fork not to sync with kotti testnet. Signed-off-by: Edward Mack <[email protected]>
Signed-off-by: Edward Mack <[email protected]>
edwardmack
force-pushed
the
ed/etc_update_sload
branch
from
2a69376
to
df56d4e
Compare
|
This is good to go. |
|
@GregTheGreek @edwardmack does this need a cherry pick for 1.4.0 this week? |
GregTheGreek
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 27, 2020
* Plugin error stack traces (hyperledger#369) Because of how the Log4J2 api works exception stack traces were not being printed. Update to use the explicit "throwable" overloaded methods. Signed-off-by: Danno Ferrin <[email protected]> * VM Trace fixes (hyperledger#372) * correct refund addresses * correct returned memory from static precompiled calls. * update integration test * precompiles sometimes get plain old CALLs Signed-off-by: Danno Ferrin <[email protected]> * Validate private transaction before sending to enclave (hyperledger#356) Signed-off-by: Jason Frame <[email protected]> * Trace API fixes (hyperledger#377) - Correct Reporting of reverts in nested call - correct reporting and handling of value transfer in nested calls - correct handling of precompiles via DELEGATECALL & CALLCODE - Addition of precompiled contract gas costs - Re-work handling of storage writes - Initial handling of gas refunds - fix bug in DELEGATECALL tests, we don't need gas in the stack * this has a cascading effect on balances in diff tests - rework depth detection in flat trace - two new tests blocks Signed-off-by: Danno Ferrin <[email protected]> * [BOUNTY-2] Add NAT Docker Support (hyperledger#368) * add docker detection Signed-off-by: Karim TAAM <[email protected]> * add port mapping detection Signed-off-by: Karim TAAM <[email protected]> * add tests and refactor ip detection Signed-off-by: Karim TAAM <[email protected]> * clean RunnerBuilder Signed-off-by: Karim TAAM <[email protected]> * clean useless modification Signed-off-by: Karim TAAM <[email protected]> * spotless Signed-off-by: Karim TAAM <[email protected]> * resolve tests issues Signed-off-by: Karim TAAM <[email protected]> * streamline auto detection Signed-off-by: Ratan Rai Sur <[email protected]> Co-authored-by: Abdelhamid Bakhta <[email protected]> Co-authored-by: Ratan Rai Sur <[email protected]> * [PIE-1798] Priv RPC acceptance tests with stub enclave. (hyperledger#330) * [PIE-1798] Added some Privacy RPC ATs with a stub enclave. Signed-off-by: Mark Terry <[email protected]> * More specific task metrics names (hyperledger#389) A prior refactoring had accidentally removed the specific task names from the metrics labels. Signed-off-by: Danno Ferrin <[email protected]> * More trace fixes (hyperledger#386) * pop flat trace context when handling halts * Better detection of precompiled and non-executed contracts * correct from address when calling in init code * fix some exotic nesting cases * correct from field for init code calls at depth >1 * correct cost on a non-call * changelog and notes Signed-off-by: Danno Ferrin <[email protected]> * adding the plugin-api javadoc jar at the root level (hyperledger#378) Signed-off-by: Joshua Fernandes <[email protected]> * BESU-56: remove erroneous links to errorprone checks (hyperledger#385) Signed-off-by: Antoine Toulme <[email protected]> * Changelog entry for multi-tenancy feature (hyperledger#394) Signed-off-by: Edward Evans <[email protected]> Signed-off-by: Jason Frame <[email protected]> * 1.5 RC Changelog (hyperledger#395) * 1.5 RC changelog additions Signed-off-by: Sally MacFarlane <[email protected]> * Fixed link (hyperledger#393) Signed-off-by: Madeline <[email protected]> Co-authored-by: Edward <[email protected]> * docker changelog (hyperledger#391) * docker changelog Signed-off-by: Ratan Rai Sur <[email protected]> * address comments Signed-off-by: Ratan Rai Sur <[email protected]> Co-authored-by: MadelineMurray <[email protected]> * Added known bug to changelog (hyperledger#388) * Added known bug Signed-off-by: Madeline <[email protected]> * Added another known bug Signed-off-by: Madeline <[email protected]> * updating version to 1.4.0-rc1 (hyperledger#397) Signed-off-by: Joshua Fernandes <[email protected]> * updating verion to 1.4.1-snapshot (hyperledger#398) Signed-off-by: Joshua Fernandes <[email protected]> * [BESU-169] cache logs bloom filters automatically. (hyperledger#367) * First iteration. Draft PR. Signed-off-by: Abdelhamid Bakhta <[email protected]> * fix SPDX header Signed-off-by: Abdelhamid Bakhta <[email protected]> * Use block broadcaster to index log bloom. Signed-off-by: Abdelhamid Bakhta <[email protected]> * Remove useless toString method Signed-off-by: Abdelhamid Bakhta <[email protected]> * spotless apply Signed-off-by: Abdelhamid Bakhta <[email protected]> * cacheLogsBloomForBlockHeader Signed-off-by: Abdelhamid Bakhta <[email protected]> * spotless apply Signed-off-by: Abdelhamid Bakhta <[email protected]> * ensurePreviousSegmentsArePresent Signed-off-by: Abdelhamid Bakhta <[email protected]> * Added CLI flag to enable / disable automatic logs bloom indexing. Signed-off-by: Abdelhamid Bakhta <[email protected]> * Create cache directory and cache file if not exist. Signed-off-by: Abdelhamid Bakhta <[email protected]> * Fix acceptance test Signed-off-by: Abdelhamid Bakhta <[email protected]> * Write cache for block only if block is new canonical head. Signed-off-by: Abdelhamid Bakhta <[email protected]> * Handling of chain reorg. Signed-off-by: Abdelhamid Bakhta <[email protected]> * fix Signed-off-by: Abdelhamid Bakhta <[email protected]> * sportless apply Signed-off-by: Abdelhamid Bakhta <[email protected]> * Address PR comments. Signed-off-by: Abdelhamid Bakhta <[email protected]> * Remove unused constant. Signed-off-by: Abdelhamid Bakhta <[email protected]> * spotless apply Signed-off-by: Abdelhamid Bakhta <[email protected]> * [BESU-25] Use Devp2p Ping packets at v5 (hyperledger#392) Broadcast that we support snappy compression Signed-off-by: Danno Ferrin <[email protected]> * Rename logs bloom indexer to log bloom cache to match CLI flag. (hyperledger#401) Changes class names, variables, and CLI flags as needed. Signed-off-by: Danno Ferrin <[email protected]> * [PIE-1798] Fail cases for multitenancy ATs (hyperledger#400) Signed-off-by: Mark Terry <[email protected]> * Private state update metadata and migration (hyperledger#404) (backport from release-1.4) Private state update metadata and migration Signed-off-by: Lucas Saldanha <[email protected]> * [PIE-2303] Automatic log bloom caching - Remove usage of pending file. (hyperledger#407) * Don't use pending file. Signed-off-by: Abdelhamid Bakhta <[email protected]> * Don't use pending file. Signed-off-by: Abdelhamid Bakhta <[email protected]> * Create a custom error when plugin is not found. (hyperledger#409) Signed-off-by: Abdelhamid Bakhta <[email protected]> * Rename method (hyperledger#412) * rename the method isPersistingState to isPersistingPrivateState because that is what it is used for Signed-off-by: Stefan Pingel <[email protected]> * rename the method isPersistingState to isPersistingPrivateState because that is what it is used for Signed-off-by: Stefan Pingel <[email protected]> * rename the method isPersistingState to isPersistingPrivateState because that is what it is used for Signed-off-by: Stefan Pingel <[email protected]> * [BOUNTY-4] Add NAT Kubernetes Support (hyperledger#410) * add kubernetes support Signed-off-by: Karim TAAM <[email protected]> * fix review issues Signed-off-by: Karim TAAM <[email protected]> * LogBloomCache - make sure the current segment is filled (hyperledger#411) Make sure we cache the current cache segment with all of the data from the beginning of the segment. Use a flip file approach since it will be a partial file until done. Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Abdelhamid Bakhta <[email protected]> * Reduce recaching in Transaction Log Bloom Filter Cache (hyperledger#415) Do a cursory cache check at start up (file is present and correct size) instead of re-generating the cache at startup. Signed-off-by: Danno Ferrin <[email protected]> * fix order of nat detector (hyperledger#414) Signed-off-by: Karim TAAM <[email protected]> * Update SLOAD_GAS cost to 200 in Aztlan Gas Calculator (#23) (hyperledger#382) * Update SLOAD_GAS cost to 200 in Aztlan Gas Calculator Change SLOAD_GAS cost in Aztlan Gas Calculator from 800 to 200 and update functions that use SLOAD_GAS. Signed-off-by: edwardmack <[email protected]> * Update SLOAD_GAS cost to 200 in Aztlan Gas Calculator Change SLOAD_GAS cost in Aztlan Gas Calculator from 800 to 200 and update functions that use SLOAD_GAS. Signed-off-by: edwardmack <[email protected]> Signed-off-by: Edward Mack <[email protected]> * remove overrides removed overrides of calculateStorageCost and calculateStorageRefundAmount in AztlanGasCalculator because these were causing aztlan fork not to sync with kotti testnet. Signed-off-by: Edward Mack <[email protected]> * merge Signed-off-by: Edward Mack <[email protected]> * Remove unused ExecutorService init/termination (hyperledger#419) Signed-off-by: Horacio Mijail Anton Quiles <[email protected]> Co-authored-by: CJ Hare <[email protected]> * Implement Eth/64 (hyperledger#425) Wire in the fork identifier into the status messages as Eth64. Signed-off-by: Danno Ferrin <[email protected]> * Adds priv_getcode (hyperledger#428) * Adds priv_getcode Signed-off-by: Joshua Richardson <[email protected]> * BESU-146 - check if success and return errorResponse otherwise (hyperledger#424) Signed-off-by: Anthony Buckle <[email protected]> Co-authored-by: CJ Hare <[email protected]> * fixed typos (hyperledger#429) Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: CJ Hare <[email protected]> * roll back on ALL-CAPS.md files for TSC proposal (hyperledger#376) Signed-off-by: Felipe Faraggi <[email protected]> * updating the changelog with 1.4.0 details (hyperledger#431) Signed-off-by: Joshua Fernandes <[email protected]> * [BESU-194] Remove max pivot block resets during fast sync (hyperledger#427) * remove max pivot block resets during fast sync * increase max retry number and fix test * change logs in the handleFailure method * change logs related to suspicious number of retries Signed-off-by: Karim TAAM <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Jason Frame <[email protected]> Co-authored-by: Karim T. <[email protected]> Co-authored-by: Abdelhamid Bakhta <[email protected]> Co-authored-by: Ratan Rai Sur <[email protected]> Co-authored-by: mark-terry <[email protected]> Co-authored-by: Joshua Fernandes <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: MadelineMurray <[email protected]> Co-authored-by: Edward <[email protected]> Co-authored-by: Lucas Saldanha <[email protected]> Co-authored-by: pinges <[email protected]> Co-authored-by: Horacio Mijail Antón Quiles <[email protected]> Co-authored-by: CJ Hare <[email protected]> Co-authored-by: anthonybuckle <[email protected]> Co-authored-by: Felipe Faraggi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Besu was compliance to the specification, but due to "consensus by the majority" we're dropping the gas price of SLOAD to 200.
Fixed Issue(s)