[2950] Support websocket binary frames #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Li <[email protected]>
Signed-off-by: Frank Li <[email protected]>
Signed-off-by: Frank Li <[email protected]>
|
@frankisawesome can you add a CHANGELOG entry for this - in CHANGELOG.md |
Signed-off-by: Frank Li <[email protected]>
macfarla
reviewed
Nov 3, 2021
CHANGELOG.md
Outdated
| ## 21.10.2 | ||
|
|
||
| ### Additions and Improvements | ||
| - Add support for binary messages (0x02) for websocket. [#2980](https://github.com/hyperledger/besu/pull/2980) |
macfarla
approved these changes
Nov 3, 2021
Signed-off-by: Frank Li <[email protected]>
…esome/besu into hotfix/websocket-binary-frames remote changes
|
Kudos, SonarCloud Quality Gate passed! |
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* [2950] Support websocket binary frames Signed-off-by: Frank Li <[email protected]> Co-authored-by: Stefan Pingel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frank Li [email protected]
PR description
Fixed Issue(s)
fixes #2950
Changelog
Failing test for sending a binary frame to websocketservice
Add support
I thought about the changelog and included a changelog update if required.