[PAN-3155] Handle discovery peers with updated endpoints #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
mbaxter
force-pushed
the
PAN-3155/handle-discovery-peers-with-updated-endpoints
branch
from
eb90775 to
6fe18b1
Compare
NicolasMassart
previously approved these changes
Sep 17, 2019
RatanRSur
suggested changes
Sep 17, 2019
...m/p2p/src/test/java/org/hyperledger/besu/ethereum/p2p/discovery/PeerDiscoveryTestHelper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Meredith Baxter <[email protected]>
Signed-off-by: Meredith Baxter <[email protected]>
RatanRSur
approved these changes
Sep 17, 2019
sambacha
pushed a commit
to blockarraygroup/besu
that referenced
this pull request
Nov 22, 2019
Fix kotti sync issue
shemnon
referenced
this pull request
in shemnon/besu
Oct 21, 2020
Signed-off-by: Danno Ferrin <[email protected]>
fab-10
added a commit
to fab-10/besu
that referenced
this pull request
Jan 10, 2024
Signed-off-by: Fabio Di Fabio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Update discovery logic to consider a peer with an unknown discovery endpoint to be unknown regardless of whether we've encountered a peer with the same node id before. This makes the discovery logic more forgiving in the face of node restarts.
If
nodeAbonds withnodeB, thennodeBleaves the network and later comes back with a different ip address or listening port,nodeAwould previously continue trying to communicate withnodeBat its original address. With these changes,nodeAwill now treat the restartednodeBas a new peer and communicate with it on its updated endpoint. Additionally,nodeB's information will be updated in the peer table so that neighbors requests return updated information on this node.