-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposes alt definition blockNumber #1696
Draft
m4sterbunny
wants to merge
5
commits into
hyperledger:main
Choose a base branch
from
m4sterbunny:1695-nitpick-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: m4sterbunny <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: m4sterbunny <[email protected]>
Signed-off-by: m4sterbunny <[email protected]>
Signed-off-by: m4sterbunny <[email protected]>
joaniefromtheblock
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an ad-hoc pass -- setting up expanded descriptions for Linea == using Besu as sot. If I find something in sot, raising it as proposal here.
curl -X POST https://linea-mainnet.infura.io/v3/<"key">
-H "Content-Type: application/json"
-d '{
"jsonrpc": "2.0",
"method": "eth_getBlockByNumber",
"params": [
"5237789",
false
],
"id": 1
}'
curl -X POST https://linea-mainnet.infura.io/v3<"key">
-H "Content-Type: application/json"
-d '{
"jsonrpc": "2.0",
"method": "eth_getBlockReceipts",
"params": [{
"blockHash": "0xd459570b5d2994a81ec1875b058f665b7f9c006172a8bd2860de87aee9569ac8"
}],
"id": 1
}'
Issue(s) fixed
A
Passing the percentile array as optional fails
curl -X POST https://linea-mainnet.infura.io/v3/<"key">
-H "Content-Type: application/json"
-d '{
"jsonrpc": "2.0",
"method": "eth_feeHistory",
"params": [
"0x5",
"latest",
],
"id": 1
}'
While empty array passes
-H "Content-Type: application/json"
-d '{
"jsonrpc": "2.0",
"method": "eth_feeHistory",
"params": [
"9964064",
"latest",
[]
],
"id": 1
}'
B
The result object schema says oldestBlock is integer, but my result provides Hexademical of the integer, i.e a string
result:
name: eth_feeHistoryLineaExampleResponse
value:
type: object
schema:
properties:
oldestBlock: '0x10b52f'
tested and response is not integer
curl -X POST
https://linea-mainnet.infura.io/v3/<"key">
-H "Content-Type: application/json"
-d '{
"jsonrpc":"2.0",
"method":"eth_getTransactionCount",
"params": [
"0x188e0B45cedd8f5e425e73c8aa7953b92115ec24",
"0x4fb66d"
],
"id":1
}'
{"jsonrpc":"2.0","id":1,"result":"0x52"}%
Fixes #1695
Preview