Add sync nodes note #1558
Closed
Add sync nodes note #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
macfarla
reviewed
Apr 4, 2024
versioned_docs/version-24.3.0/private-networks/how-to/configure/consensus/qbft.md
Outdated
Show resolved
Hide resolved
macfarla
approved these changes
Apr 5, 2024
alexandratran
requested changes
Apr 5, 2024
There was a problem hiding this comment.
I don't think a note in this section on this page makes sense, since the section is describing how to define the QBFT genesis file, but the sync mode is configured on the command line, not the in the genesis file.
My recommendation:
- Remove the note from this page.
- Instead, add a note in the Run a node on a private network section stating that if you're running a node on a QBFT or IBFT 2.0 network, you must use full sync or fast sync (full sync is set by default).
- Also add a note to the
sync-modeoption description stating that if you're running a node on a QBFT or IBFT 2.0 network, you must use full sync or fast sync. - Add a note to the Run a full node section stating that checkpoint and snap sync are not available for QBFT and IBFT 2.0 networks.
joaniefromtheblock
force-pushed
the
1530-sync-nodes
branch
from
9eb9bfe
to
2c7ae79
Compare
joaniefromtheblock
force-pushed
the
1530-sync-nodes
branch
from
ad1c118
to
7569d4f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1530
Adds note on full and fast sync for BFT