-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 0003 Protocols - Added note about always ignoring unrecognized items in a message #527
Conversation
…n if the protocol minor versions match Signed-off-by: Stephen Curran <[email protected]>
@TimoGlastra -- this came up in the https://github.com/bcgov/aries-agent-test-harness when a test failed in ACA-Py based on a message from aries-framework-dotnet that had an unrecognized field that I think you mentioned was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks good to me, and this was discussed and approved on a community call. Merging. |
@swcurran It was indeed the
I'm curious if this also applies to the issue we had with the optional comment property in messages from .NET -> ACA-Py where ACA-Py only allowed the property to be of type string or for it to be left out, but .NET sends |
@TimoGlastra That's an interesting side note: what does |
Could someone else take a shot at that? I'm not the one to write that -- it gets a bit too far into JSON handling best practices for me. |
Also corrected the name of the problem-report message (vs. the report problem protocol name).