tweak: add named states to RFCs 0036, 0037 per issue #408 #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Hardman <[email protected]>
swcurran
reviewed
Feb 4, 2020
swcurran
reviewed
Feb 4, 2020
swcurran
reviewed
Feb 4, 2020
swcurran
reviewed
Feb 4, 2020
swcurran
requested changes
Feb 4, 2020
dhh1128
changed the title
dhh1128
changed the title
Signed-off-by: Daniel Hardman <[email protected]>
Signed-off-by: Daniel Hardman <[email protected]>
Signed-off-by: Daniel Hardman <[email protected]>
|
@swcurran : I think I've now resolved all of your requested changes, except for a non-happy-path state. Not sure what to do with that. Do you have suggestions? |
swcurran
approved these changes
Mar 20, 2020
|
Sorry for the delay in merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Hardman [email protected]