Fix crash during pickup if network is turned off #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Chatterji <[email protected]>
Signed-off-by: Varun Chatterji <[email protected]>
conanoc
reviewed
Nov 20, 2023
| try { | ||
| agent.messageSender.send(message) | ||
| } catch (e: Exception) { | ||
| // We catch the exception here because if there is a network failure |
There was a problem hiding this comment.
This comment seems too verbose.
| } else if (agent.agentConfig.mediatorPickupStrategy == MediatorPickupStrategy.Implicit) { | ||
| // For implicit pickup, responseRequested must be set to false. | ||
| // Since no response is requested, the mediator can respond with queued messages. | ||
| // Otherwise, it would respond with a trust ping response. | ||
| val message = OutboundMessage(TrustPingMessage("pickup", false), mediatorConnection) | ||
| agent.messageSender.send(message, "ws") | ||
| try { | ||
| // We catch the exception here because if there is a network failure |
|
@conanoc I am ok with the changes but I cannot approve them in the review as I am the author. Would you like me to commit again with the comments removed? |
Signed-off-by: Varun Chatterji <[email protected]>
|
@conanoc removed the comments and committed again. |
|
Looks good to me. |
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, if the network is turned off, pickup of messages causes an application crash.
This PR fixes this by silently ignoring crashes during a pickup (as pickup will be retried at the polling frequency specified).
Also, there was no exception handling during the establishment of a connection (in the
WalletMainActivity), this has been fixed too.@conanoc / @DrumRobot request you to review this and merge.