feat: add validation to JSON transformer

[morrieinmaas]

closes #742
Signed-off-by: Moriarty [email protected]

[morrieinmaas]

Thanks for all the feedback!

[codecov-commenter]

Codecov Report

Merging #830 (ff330a2) into main (1f8b6ab) will decrease coverage by 0.00%.
The diff coverage is 92.59%.

@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
- Coverage   87.57%   87.57%   -0.01%     
==========================================
  Files         463      465       +2     
  Lines       11083    11097      +14     
  Branches     1745     1753       +8     
==========================================
+ Hits         9706     9718      +12     
- Misses       1377     1379       +2     

Impacted Files	Coverage Δ
.../modules/connections/services/ConnectionService.ts	87.14% <ø> (+0.19%)	⬆️
...ore/src/modules/dids/methods/web/WebDidResolver.ts	60.00% <ø> (+1.17%)	⬆️
packages/core/src/error/ClassValidationError.ts	75.00% <75.00%> (ø)
packages/core/src/utils/MessageValidator.ts	90.00% <88.88%> (-10.00%)	⬇️
packages/core/src/utils/JsonTransformer.ts	94.73% <90.90%> (-5.27%)	⬇️
packages/core/src/agent/Agent.ts	95.89% <100.00%> (ø)
packages/core/src/agent/MessageReceiver.ts	80.76% <100.00%> (-0.54%)	⬇️
packages/core/src/agent/MessageSender.ts	84.61% <100.00%> (ø)
packages/core/src/error/ValidationErrorUtils.ts	100.00% <100.00%> (ø)
packages/core/src/error/index.ts	100.00% <100.00%> (ø)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f8b6ab...ff330a2. Read the comment docs.

[TimoGlastra]

This is a great addition @morrieinmaas! Left some notes mainly on the disabling of validation. The goal to integrate validation with transformation is to get rid of these hidden errors, so would be great if we could fix as much validation errors as possible

[morrieinmaas]

Thanls for all the feedback @TimoGlastra. sorry hadn't managed to write up some more context. From running the tests it became clear the the sync check method doesn't validate as reliably as the async one. That resulted in some tests failed as they were. Was sort of a catch 22 situation when writing this last Friday.

Also, I'll add more in detail to your comments above, but essentially I was a little unsure of how consistent with the previous implementation we want to keep it aka not introducing breaking changes. I'll have another fresh look. Maybe I was over-complicating things and missed the elegant way

[morrieinmaas]

I'll have another go at it today to incorporate your suggestions

[TimoGlastra]

I was a little unsure of how consistent with the previous implementation we want to keep it aka not introducing breaking changes

I think the previous implementation has some issues so it's fine to introduce some breaking changes if they improve behaviour

[morrieinmaas]

Also random question - I've had some tests failing locally that then worked on remote due to snapshot obsolete. How can I fix this?

[TimoGlastra]

Also random question - I've had some tests failing locally that then worked on remote due to snapshot obsolete. How can I fix this?

Can you share the error log?

[morrieinmaas]

here is the entire output of yarn test. Those tests don't fail on remote. Not sure what to do about obsolete snapshots

[TimoGlastra]

I think your environement got corrupted. To clean you can do the following to delete all indy wallets:

rm -rf ~/.indy_client

And as you don't have a postgres database running locally you can run the tests with:

yarn test --testPathIgnorePatterns ./packages/core/tests/postgres.test.ts

Can you see if the errors still persist?

[TimoGlastra]

weird this is losing all this data. If you solve this one error, will it give a new error? (i.e. it will deliver them one by one instead)

[TimoGlastra]

A lot of work went into this PR, great work @morrieinmaas!

[TimoGlastra]

@blu3beri can you give a review to unblock or leave more feedback?

[morrieinmaas]

A lot of work went into this PR, great work @morrieinmaas!

haha puuh that's come a long way. thanks for all the feedback and assistance.🙏

[berendsliedrecht]

Unblocked.