Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create test util for catching errors #874

Closed
morrieinmaas opened this issue Jun 16, 2022 · 3 comments
Closed

create test util for catching errors #874

morrieinmaas opened this issue Jun 16, 2022 · 3 comments

Comments

@morrieinmaas
Copy link
Contributor

see this PR comment for more detail

Happy to work on this.

@Iskander508
Copy link
Contributor

@morrieinmaas
Copy link
Contributor Author

@Iskander508 This is different in the way that it allows to catch the entire error object and do some more validation on this. The link above is just the example. With the expect(...).toThrow(Error) you are limited with the validation you can do in one go (eg validate error of type x is thrown or error message x is present). It's just a little bit of extra scrutiny

@TimoGlastra
Copy link
Contributor

Doesn't seem so relevant anymore. We can add it when the need arises

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants